Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the LICENSE file correct? (Generally GPL v3 for sims and MIT for common code, see this thread for additional information). #45

Closed
Tracked by #5
samreid opened this issue Aug 11, 2021 · 2 comments
Closed
Tracked by #5

Is the LICENSE file correct? (Generally GPL v3 for sims and MIT for common code, see this thread for additional information). #45

samreid opened this issue Aug 11, 2021 · 2 comments
Assignees
@zepumph
Labels
dev:code-review

Comments

@samreid
Copy link
Member

samreid commented Aug 11, 2021 •
edited
Loading

For circuit-construction-kit-common, it was decided that repo should be licensed as GPL since it is very sim-specific, I suspect the same applies for density-buoyancy-common. For #5.

Should we also update the code review document?
@samreid samreid mentioned this issue Aug 11, 2021
Closed
jonathanolson added a commit that referenced this issue Aug 11, 2021
@jonathanolson
License update to GPL3, see #45
da678a0
@jonathanolson
Copy link
Contributor

Sounds good to me, @kathy-phet can you verify?

Should we also update the code review document?

Also, @kathy-phet, does this sound correct in general?

@AgustinVallejo AgustinVallejo assigned zepumph and unassigned kathy-phet Feb 9, 2024
zepumph added a commit to phetsims/phet-info that referenced this issue Mar 26, 2024
@zepumph
update doc and support auto format, phetsims/density-buoyancy-common#45
9a96b60 
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
@zepumph
Copy link
Member

zepumph commented Mar 26, 2024

That seems very reasonable to me! Updated to CRC to note "very sim-like common repos" as GPL v3.

@zepumph zepumph closed this as completed Mar 26, 2024
@marlitas marlitas mentioned this issue May 22, 2024
Closed
81 tasks
@samreid samreid mentioned this issue Jun 5, 2024
Closed
84 tasks
@marlitas marlitas mentioned this issue Jun 7, 2024
Closed
81 tasks
@pixelzoom pixelzoom mentioned this issue Feb 10, 2025
Closed
88 tasks
@AgustinVallejo AgustinVallejo mentioned this issue Feb 10, 2025
Open
89 tasks
@pixelzoom pixelzoom mentioned this issue Feb 11, 2025
Closed
87 tasks
@jbphet jbphet mentioned this issue Feb 14, 2025
Open
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathanolson @samreid @kathy-phet @zepumph