-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properties should use type-specific subclasses where appropriate (e.g. BooleanProperty, NumberProperty, StringProperty) or provide documentation as to why they are not. #46
Comments
I just fixed up what I was able to find. I definitely didn't see any place where EnumerationProperty could be used that isn't, could you clarify? Additionally, should we open up a common code issue about Vector3Property, Bounds3Property, and other things not existing that I would have expected would have been kept in-line with the other dimensional equivalents? |
Could EnumerationProperty be used in cases like these: this.interiorMaterialProperty = new Property( BOTTLE_INITIAL_INTERIOR_MATERIAL );
new Property( Material.WOOD )
new Property( Gravity.EARTH, { etc? |
Perhaps phetsims/axon#221 was intended for that? I'm OK with any of these plans:
What do you recommend? |
Not that I'm aware of, custom gravities and materials are created dynamically and seem unsuitable to Enumeration. If there's a way to provide better phet-io support, let me know.
I'd defer to your judgment, I'm fine to not make changes. |
Thanks, I forgot about the custom ones. All seems well, closing. |
For #5, I saw several places that could use EnumerationProperty, and some that could use Vector2Property.
The text was updated successfully, but these errors were encountered: