Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes that mix in traits or mixin should use the @mixes MyType annotation. #49

Closed
Tracked by #5
samreid opened this issue Aug 11, 2021 · 2 comments
Closed
Tracked by #5

Classes that mix in traits or mixin should use the @mixes MyType annotation. #49

samreid opened this issue Aug 11, 2021 · 2 comments
Assignees
@samreid
Labels
dev:code-review

Comments

@samreid
Copy link
Member

samreid commented Aug 11, 2021 •
edited
Loading

From #5, there seem to be several mixins that don't use @mixes.
@samreid samreid mentioned this issue Aug 11, 2021
Closed
jonathanolson added a commit that referenced this issue Aug 11, 2021
@jonathanolson
Adding @mixes, see #49
c81c7d0
@jonathanolson
Copy link
Contributor

Handled above, only saw the Modal mixin.

@samreid
Copy link
Member Author

samreid commented Aug 11, 2021

Excellent, thanks! Closing.

@samreid samreid closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid