Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put qualifiers in parenthesis after the annotation, #55

Closed
samreid opened this issue Aug 11, 2021 · 2 comments
Closed

Put qualifiers in parenthesis after the annotation, #55

samreid opened this issue Aug 11, 2021 · 2 comments
Assignees
@samreid
Labels
dev:code-review

Comments

@samreid
Copy link
Member

samreid commented Aug 11, 2021

From #5, I would have expected to see more attributes marked as read-only, but I didn't see any. @jonathanolson can you please take a look?
jonathanolson added a commit that referenced this issue Aug 12, 2021
@jonathanolson
Adding read-only qualifiers, see #55
52f961e
@jonathanolson
Copy link
Contributor

Added read-only qualifiers above.

@samreid
Copy link
Member Author

samreid commented Aug 12, 2021

Looks great, thanks! Closing.

@samreid samreid closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid