Use EnergySkateParkBasicsModel.addTrack more broadly

[jessegreenberg]

From a TODO:

    /**
     * Add a track, called by phet-io in setState (to restore a state).
     * TODO: this code should be called by EnergySkateParkBasicsModel too.
     * @param {Tandem} tandem
     * @param {boolean} interactive - whether the track can be dragged.
     * @param controlPointTandemIDs
     */
    addTrack: function( tandem, interactive, controlPointTandemIDs ) {

@samreid do you still believe this TODO still applies?

[samreid]

I think it is worth investigation, thought it may not pan out. I don't see a quick way to solve this, it will probably involve experimentation/investigation and would require specifying the control point indices as arguments to the function (though that's unclear how it will work with PhET-iO where the control point locations are set separately).

@jessegreenberg how do you recommend to proceed?

[jessegreenberg]

I see, thanks. Ill take a look.

[samreid]

Thanks, and good luck. You can use the phet-io "state" wrapper to exercise addTrack.

[jessegreenberg]

Moving to energy-skate-park now, I had forgotten about this and will work on it now.

[samreid]

PhetioGroup should be used for this part. Are you preparing for phet-io and phet brand publication for the new sim, or only PhET-brand?

[jessegreenberg]

Only PhET brand - should this wait until a PhET-iO publication?

[samreid]

I think this sim should be changed to use PhetioGroup when it is time to instrument the sim, or when we eliminate the legacy pattern as part of phetsims/tandem#87

[jessegreenberg]

OK thanks, in that case this issue can be picked up at that point.

[samreid]

I deleted this method, and we will continue with the pattern established in #123