Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the game score at which the reward is shown #203

Open
pixelzoom opened this issue Nov 8, 2022 · 2 comments
Open

Set the game score at which the reward is shown #203

pixelzoom opened this issue Nov 8, 2022 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

From 11/8/2022 design meeting... The PhET-iO client should be able to set the game score at which the reward is shown.

TODO:

  • make rewardScore a public query parameter
  • add solveItScreen.model.rewardScoreProperty, initialized with EqualityExplorerQueryParameters.rewardScore
  • add phetioDocumentation for rewardScoreProperty
@pixelzoom pixelzoom self-assigned this Nov 8, 2022
pixelzoom added a commit that referenced this issue Nov 8, 2022
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Nov 8, 2022

@amanda-phet please review.

  • ?rewardScore is now a public query parameter. It must be a positive integer, and it defaults to 10. If you use an invalid value, you'll see any Oops dialog when the sim starts.
  • equalityExplorer.solveItScreen.model.rewardScoreProperty is the new Property. Its initial value is the query parameter ?rewardScore. This Property can be changed via PhET-iO. It's presentation in Studio is shown below.
  • Note that if you were to play 5 challenges, then set rewardScoreProperty to 4, you're never going to see a reward. A reward is given once per level, at exactly the score indicated by rewardScoreProperty.

screenshot_1948

@pixelzoom
Copy link
Contributor Author

Deferred -- this issue will not be part of the 1.2 release, since that release will not include PhET-iO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants