Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.md #70

Closed
pixelzoom opened this issue Jan 30, 2024 · 8 comments
Closed

model.md #70

pixelzoom opened this issue Jan 30, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 30, 2024

https://github.com/phetsims/faradays-electromagnetic-lab/blob/main/doc/model.md

@pixelzoom pixelzoom added the documentation Improvements or additions to documentation label Jan 30, 2024
@pixelzoom pixelzoom self-assigned this Feb 27, 2024
This was referenced Mar 13, 2024
pixelzoom added a commit to phetsims/magnets-and-electromagnets that referenced this issue Mar 13, 2024
pixelzoom added a commit to phetsims/magnet-and-compass that referenced this issue Mar 13, 2024
pixelzoom added a commit to phetsims/generator that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
@pixelzoom
Copy link
Contributor Author

@arouinfar model.md is ready for review. Feel free to make changes/corrections directly.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
arouinfar added a commit that referenced this issue Mar 14, 2024
@arouinfar
Copy link
Contributor

Looks good @pixelzoom! I made a few small edits in the commit above.

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
@pixelzoom
Copy link
Contributor Author

Assigned to @samreid and @matthew-blackman as part of code review #103.

@pixelzoom
Copy link
Contributor Author

Issues #117, #118, and #119 all deal with how this sim does (and does not) deal with resistance and current. To address those issue, @matthew-blackman will take a stab at improving related documentation in model.md. @arouinfar and I will review.

@matthew-blackman
Copy link
Contributor

I added a note about the wire length in the 'Electromagnet' section. Over to you for review @arouinfar and @pixelzoom.

@pixelzoom
Copy link
Contributor Author

Thanks @matthew-blackman, looks good to me.

@pixelzoom pixelzoom removed their assignment Apr 3, 2024
@arouinfar
Copy link
Contributor

Looks good to me too, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status:ready-for-review
Projects
None yet
Development

No branches or pull requests

4 participants