Added REVIEW comments #29

phetsims · Dec 21, 2018 · 95ae2ea · 95ae2ea
1 parent adeeeda
commit 95ae2ea
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/js/building/model/Animator.js b/js/building/model/Animator.js
@@ -21,6 +21,7 @@ define( require => {
     constructor( config ) {
 
       // REVIEW: Should "config" be named "options"? This may just be a matter of preference.
+      // REVIEW: (Review amendment) I see we are using the config pattern here, not too sure of the difference from options.
       config = _.extend( {
 
         // {Property.<Vector2>}

diff --git a/js/fractions-common-tests.js b/js/fractions-common-tests.js
@@ -1,5 +1,6 @@
 // Copyright 2018, University of Colorado Boulder
 
+// REVIEW: Author notation is different from other files. Was this intentional?
 /**
  * Unit tests. Please run once in phet brand.
  *

diff --git a/js/fractionsCommon.js b/js/fractionsCommon.js
@@ -8,6 +8,7 @@
 define( require => {
   'use strict';
 
+  // REVIEW: 'const' instead of 'var'
   // modules
   var Namespace = require( 'PHET_CORE/Namespace' );