Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home/navigation icons #30

Closed
jonathanolson opened this issue Dec 13, 2018 · 13 comments
Closed

Home/navigation icons #30

jonathanolson opened this issue Dec 13, 2018 · 13 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

Let me know when we have navbar / homescreen icons and I can put them in.

@amanda-phet
Copy link

Thoughts on these icons?

image

image

image

image

For the Intro screens I would make a modified icon for the navbar with just one representation, but I think it's nice to see a medley on the homescreen icon.

@jonathanolson
Copy link
Contributor Author

Those all look like they can be generated in code, so presumably I'd prefer to do it that way once the design is finalized unless I hear otherwise?

@kathy-phet
Copy link

Here are my suggestions ... take them or leave them.

Fractions Intro = screen 2 look good. on screen 3 can you make them match (both be 3 quarters?)? the screen 1 icon - can we put the number fraction in there and remove the cup. also numberline should be less than 1 - that is the fractions should all match.
Can you include a proposal for the small icon too?

Fractions: Mixed Numbers = looks good to me

Fractions: Equality = looks good to me

Build a Fraction = looks good to me

@ariel-phet
Copy link

@amanda-phet I think everything looks good except "Intro" on Fractions: Intro and Fractions: Mixed Numbers. Both of those look a bit busy, and might not work well on the nav bar. I think as long as it looks different than the other screens, it doesn't have to perfectly represent all that is on the screen. Maybe just the number and the numberline?

@amanda-phet
Copy link

How about this- I reduced the number of fractions down to 2 for both intro screens and tweaked the representations slightly. I agree it has to look different than the other screens, but representing the differentiating content of each screen is important.

Fractions: Intro
image
image

Fractions: Mixed Numbers
image
image

@kathy-phet
Copy link

Looks good to me

@amanda-phet
Copy link

@jonathanolson I think code is definitely the best way to generate these. Let me know if you need anything else from me.

@jonathanolson
Copy link
Contributor Author

Icons should be added in the above commits. Can you see how things look?

@ariel-phet
Copy link

All is looking pretty good to me, except on "Fractions: Mixed Numbers" the Intro Screen icon on the navbard is a bit hard to see. Maybe use a smaller segment of the number line and make it a bit more prominent (such as put the dot a 1 1/2, and only show the number line from 0 to 2).

@jonathanolson
Copy link
Contributor Author

Updated master, how does it look now?

@amanda-phet
Copy link

I like that change.

The only thing I am seeing: The Fraction Matcher game screen icon is being used in Fractions Equality, but the navbar icon looks really strange in Fractions Equality. I'm wondering if we need to specify an icon for this sim that is different from the Fraction Matcher sim. @jonathanolson can we do that? Perhaps just use the main home screen icon in the navbar.
image

image

@ariel-phet ariel-phet removed their assignment Jan 4, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jan 10, 2019
@jonathanolson
Copy link
Contributor Author

Implemented with the above (fractions-equality repo) commit. Can you see how it looks now?

@jonathanolson jonathanolson removed their assignment Jan 10, 2019
@amanda-phet
Copy link

Looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants