Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim fails when returning pieces to bucket #36

Closed
Denz1994 opened this issue Dec 19, 2018 · 2 comments
Closed

Sim fails when returning pieces to bucket #36

Denz1994 opened this issue Dec 19, 2018 · 2 comments
Assignees
Labels
dev:code-review type:bug Something isn't working

Comments

@Denz1994
Copy link
Contributor

Found during: #29

Steps to reproduce:
Note this is the most consistent means of reproduction, but it may not be limited to this interaction.

  1. Open sim to Mixed-Numbers screen.
  2. Click on level 1 (for low difficultly).
  3. Solve a problem that involves using a whole shape.
  4. Drag a new empty shape container into the play area.
  5. Click on the plus sign to add more empty shape containers to the shape group within the play area.
  6. Drag the whole shape pieces into the empty shape containers.
  7. Click the minus button on the shape group.

Sorry for the long list of steps but I've finally been able to track down one method of reproducing this bug. I can demonstrate via video call if need be.

ShapeGroup.js?bust=1545250767622:133 Uncaught TypeError: this.returnPieceListener is not a function
at ShapeGroup.decreaseContainerCount (ShapeGroup.js?bust=1545250767622:133)
at Emitter.emit (Emitter.js?bust=1545250767622:202)
at PushButtonModel.fire (PushButtonModel.js?bust=1545250767622:155)
at Array.downPropertyObserver (PushButtonModel.js?bust=1545250767622:88)
at Emitter.emit3 (Emitter.js?bust=1545250767622:284)
at BooleanProperty._notifyListeners (Property.js?bust=1545250767622:288)
at BooleanProperty.setValueAndNotifyListeners (Property.js?bust=1545250767622:270)
at BooleanProperty.set (Property.js?bust=1545250767622:203)
at Emitter.emit3 (Emitter.js?bust=1545250767622:284)
at BooleanProperty._notifyListeners (Property.js?bust=1545250767622:288)

@jonathanolson
Copy link
Contributor

I believe the above commit should solve this issue. Can you verify?

@Denz1994
Copy link
Contributor Author

Works great. Closing this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:code-review type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants