changed the way score displays are provided to status bars and level …

…selection buttons to be more type safe, see phetsims/vegas#102
phetsims · Jun 20, 2022 · 3a95094 · 3a95094
1 parent 736b274
commit 3a95094
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/js/linegame/view/PlayNode.js b/js/linegame/view/PlayNode.js
@@ -30,7 +30,7 @@ class PlayNode extends Node {
     super();
 
     const statusBar = new FiniteStatusBar( layoutBounds, visibleBoundsProperty, model.scoreProperty, {
-      scoreDisplayConstructor: ScoreDisplayLabeledNumber,
+      createScoreDisplay: scoreProperty => new ScoreDisplayLabeledNumber( scoreProperty ),
 
       // FiniteStatusBar uses 1-based level numbering, model is 0-based, see #88.
       levelProperty: new DerivedProperty( [ model.levelProperty ], level => level + 1 ),

diff --git a/js/linegame/view/SettingsNode.js b/js/linegame/view/SettingsNode.js
@@ -125,11 +125,10 @@ function createLevelSelectionButton( level, model, levelImage ) {
     buttonHeight: 210,
     bestTimeProperty: model.bestTimeProperties[ level ],
     bestTimeVisibleProperty: model.timerEnabledProperty,
-    scoreDisplayConstructor: ScoreDisplayStars,
-    scoreDisplayOptions: {
+    createScoreDisplay: scoreProperty => new ScoreDisplayStars( scoreProperty, {
       numberOfStars: model.challengesPerGameProperty.get(),
       perfectScore: model.getPerfectScore( level )
-    },
+    } ),
     listener: () => {
       model.levelProperty.set( level );
       model.setGamePhase( GamePhase.PLAY );