Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separator at top of accordion box is missing. #149

Closed
pixelzoom opened this issue Apr 2, 2024 · 1 comment
Closed

Separator at top of accordion box is missing. #149

pixelzoom opened this issue Apr 2, 2024 · 1 comment
Assignees
@pixelzoom
Labels
type:bug

Comments

@pixelzoom
Copy link
Contributor

For phetsims/qa#1061 ...

I just noticed that we've lost the horizontal separator between the accordion box title and the interactive equation. This is because scenery layout automatically hides any separators that do not have a visible Node on both sides of them.

For example in the Slope screen, published:

screenshot_3166

...versus main:

screenshot_3167
@pixelzoom pixelzoom self-assigned this Apr 2, 2024
pixelzoom added a commit that referenced this issue Apr 2, 2024
@pixelzoom
factor out const SEPARATOR_OPTIONS, #149
607e845
@pixelzoom pixelzoom mentioned this issue Apr 2, 2024
Open
pixelzoom added a commit that referenced this issue Apr 2, 2024
@pixelzoom
show separator at top of accordion box content, #149
588aae3
@pixelzoom
Copy link
Contributor Author

Fixed in the above commits, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom