Skip to content

Commit

Permalink
phetioFeatured:false for individual radio buttons, #300
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jun 19, 2023
1 parent 7686a5f commit e95977b
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions js/common/view/GreenhouseGasConcentrationPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import Utils from '../../../../dot/js/Utils.js';
import optionize, { combineOptions } from '../../../../phet-core/js/optionize.js';
import { Circle, Color, FlowBox, HBox, Line, Node, Path, Rectangle, RichText, Text, VBox } from '../../../../scenery/js/imports.js';
import calendarAltRegularShape from '../../../../sherpa/js/fontawesome-5/calendarAltRegularShape.js';
import RectangularRadioButtonGroup, { RectangularRadioButtonGroupOptions } from '../../../../sun/js/buttons/RectangularRadioButtonGroup.js';
import RectangularRadioButtonGroup, { RectangularRadioButtonGroupItem, RectangularRadioButtonGroupOptions } from '../../../../sun/js/buttons/RectangularRadioButtonGroup.js';
import Panel, { PanelOptions } from '../../../../sun/js/Panel.js';
import VSlider from '../../../../sun/js/VSlider.js';
import Tandem from '../../../../tandem/js/Tandem.js';
Expand Down Expand Up @@ -542,7 +542,7 @@ class ConcentrationControlModeRadioButtonGroup extends RectangularRadioButtonGro

const dummyProperty = new NumberProperty( 5, { range: new Range( 0, 10 ) } );

const items = [
const items: RectangularRadioButtonGroupItem<ConcentrationControlMode>[] = [
{
createNode: () => new VSlider( dummyProperty, dummyProperty.range, {
trackSize: new Dimension2( 2, dateIcon.height - 9 ),
Expand Down Expand Up @@ -576,6 +576,16 @@ class ConcentrationControlModeRadioButtonGroup extends RectangularRadioButtonGro
combineOptions<RectangularRadioButtonGroupOptions>( {
orientation: 'horizontal' as const,

// See https://github.com/phetsims/greenhouse-effect/issues/300#issuecomment-1597373083
radioButtonOptions: {
visiblePropertyOptions: {
phetioFeatured: false
},
enabledPropertyOptions: {
phetioFeatured: false //TODO https://github.com/phetsims/greenhouse-effect/issues/300 does not get applied!
}
},

// pdom
labelTagName: 'h4',
labelContent: GreenhouseEffectStrings.a11y.concentrationPanel.experimentModeStringProperty,
Expand Down

0 comments on commit e95977b

Please sign in to comment.