Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getNextPreviousFocusable doesn't work in IE #206

Closed
jessegreenberg opened this issue Mar 31, 2017 · 6 comments
Closed

getNextPreviousFocusable doesn't work in IE #206

jessegreenberg opened this issue Mar 31, 2017 · 6 comments
Assignees
@jessegreenberg
Labels
type:bug

Comments

@jessegreenberg
Copy link
Contributor

No description provided.

@jessegreenberg jessegreenberg self-assigned this Mar 31, 2017
@jessegreenberg
Copy link
Contributor Author

This is probably caused by someething similar to #203.

@jessegreenberg
Copy link
Contributor Author

Nothing in IE is focusable when the dev tools are open 😠

@jessegreenberg
Copy link
Contributor Author

IE says that ul elements have tabindex=0??

@jessegreenberg
Copy link
Contributor Author

Also li elements.

@jessegreenberg
Copy link
Contributor Author

Come on IE...

In a result table below I grouped all browsers, except IE, due to the fact that IE gives totally other results than the rest.

https://nemisj.com/focusable/

jessegreenberg added a commit to phetsims/scenery that referenced this issue Apr 2, 2017
@jessegreenberg
flag unfocusable elements with tabindex for IE, see phetsims/john-tra…
b8b0944 
…voltage#206
@jessegreenberg
Copy link
Contributor Author

Fixed with the above commit. Scenery now flags elements in the PDOM that are not focusable with an explicit tabindex="-1" so that we can skip them when searching for the next focusable. Closing.

@jessegreenberg jessegreenberg mentioned this issue Apr 3, 2017
Closed
@jessegreenberg jessegreenberg mentioned this issue Sep 5, 2017
Closed
@jessegreenberg jessegreenberg mentioned this issue Nov 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg