Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiding the massSection on the lab screen can look odd #311

Closed
Tracked by #1029
Nancy-Salpepi opened this issue Dec 5, 2023 · 8 comments
Closed
Tracked by #1029

hiding the massSection on the lab screen can look odd #311

Nancy-Salpepi opened this issue Dec 5, 2023 · 8 comments

Comments

@Nancy-Salpepi
Copy link

Test device
Dell

Operating System
Win10

Browser
chrome

Problem description
For phetsims/qa#1008, one of the examples is to hide the mass section by setting mySolarSystem.labScreen.view.panels.valuesPanel.massSection.visibleProperty to false. If 'More Data' isn't checked, the result is this:
Screenshot 2023-12-05 at 4 28 42 PM

@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Dec 5, 2023

Deleted this last comment because it is definitely a bug. (#312)

@pixelzoom
Copy link
Contributor

I'll take this one.

@pixelzoom pixelzoom assigned pixelzoom and unassigned arouinfar Dec 5, 2023
@pixelzoom
Copy link
Contributor

@arouinfar and I discussed. There's nothing we can do to prevent this configuration, it's a possible intermediate state in configuring valuesPanel, and it will hopefully be obvious to the instructional design that this should not be the final state. We will make no code/instrumentation changes. @arouinfar will elaborate on this and #312 in examples.md, then pass back to @Nancy-Salpepi to review.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Dec 5, 2023
@arouinfar
Copy link
Contributor

I added this snippet to the section related to setting massSection.visibleProperty to false.
https://github.com/phetsims/phet-io-sim-specific/blob/main/repos/my-solar-system/examples.md#limit-which-data-is-accessible-to-students

When hiding the massSection we recommend setting moreDataVisibleProperty to true and hiding the "More Data" checkbox, using the phetioIDs provided at the beginning of this section.

@Nancy-Salpepi please review and close if it looks OK.

@arouinfar arouinfar assigned Nancy-Salpepi and unassigned arouinfar Dec 8, 2023
@Nancy-Salpepi
Copy link
Author

Perfect addition!
Closing.

@Nancy-Salpepi
Copy link
Author

Reopening for phetsims/qa#1015 because the change I see in the link in #311 (comment) is not present in the examples.md in https://phet-dev.colorado.edu/html/my-solar-system/1.3.0-rc.1/phet-io

@AgustinVallejo
Copy link
Contributor

The spot check here is to make sure this change is in examples.md

@Nancy-Salpepi
Copy link
Author

The change is in examples.md. in rc.4

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants