You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As reported in phetsims/scenery#1676 (comment), the addAMateButton and subsequently its firedEmitter are read-only. However, the code comment indicates that the visibleProperty was meant to be read-only. If I understand correctly, this patch will correct the problem:
Subject: [PATCH] Use PhetioIDUtilsModule, see https://github.com/phetsims/tandem/issues/316
---
Index: js/common/view/PlayButtonGroup.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================diff --git a/js/common/view/PlayButtonGroup.ts b/js/common/view/PlayButtonGroup.ts--- a/js/common/view/PlayButtonGroup.ts (revision ff948a96c9fe819eb78591281b69de3729110577)+++ b/js/common/view/PlayButtonGroup.ts (date 1734387307472)@@ -152,9 +152,9 @@
cornerRadius: 5,
xMargin: 12,
yMargin: 8,
- phetioReadOnly: true, // because sim state controls when this button is visible
visiblePropertyOptions: {
- phetioFeatured: false+ phetioFeatured: false,+ phetioReadOnly: true // because sim state controls when this button is visible
},
enabledPropertyOptions: {
phetioFeatured: false
Please remember to regenerate the phet-io API when making this change.
The text was updated successfully, but these errors were encountered:
As reported in phetsims/scenery#1676 (comment), the
addAMateButton
and subsequently itsfiredEmitter
are read-only. However, the code comment indicates that the visibleProperty was meant to be read-only. If I understand correctly, this patch will correct the problem:Please remember to regenerate the phet-io API when making this change.
The text was updated successfully, but these errors were encountered: