New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading names for "number of masses" #89

Open

pixelzoom opened this issue Sep 14, 2023 · 0 comments

Labels

dev:code-review

Contributor

pixelzoom commented Sep 14, 2023

"Number of mass" seems to actually be the "number of masses per row". Confirm and rename these things:

In NormalModesConstants:

NUMBER_OF_MASSES_RANGE: NUMBER_OF_MASSES_RANGE, //TODO actually number of masses PER ROW

In NormalModesModel:

    // @public {Property.<number>} the current number of visible masses
    //TODO this is actually the number of masses per row. In the 'Two Dimensions' screen, the number of masses is this value squared. https://github.com/phetsims/tasks/issues/1129
    this.numberOfMassesProperty = new NumberProperty( options.numberOfMasses, {

pixelzoom added the dev:code-review label

pixelzoom added a commit that referenced this issue


          TODO #89, phetsims/tasks#1129

d1bbee8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment