Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Credits #39

Closed
Tracked by #695
SaurabhTotey opened this issue Jul 6, 2021 · 8 comments
Closed
Tracked by #695

Finalize Credits #39

SaurabhTotey opened this issue Jul 6, 2021 · 8 comments

Comments

@SaurabhTotey
Copy link
Member

Standard code review issue created for #35. Should be addressed before publication.

@SaurabhTotey SaurabhTotey mentioned this issue Jul 6, 2021
@SaurabhTotey SaurabhTotey mentioned this issue Jul 18, 2021
@pixelzoom
Copy link
Contributor

As of code review #35, the credits are completed empty. It would be good to take a stab at filling these in before the first dev test. At this point in the development, you should know everything except QA credits.

SaurabhTotey pushed a commit that referenced this issue Jul 30, 2021
SaurabhTotey pushed a commit that referenced this issue Jul 30, 2021
SaurabhTotey pushed a commit that referenced this issue Jul 30, 2021
SaurabhTotey pushed a commit that referenced this issue Jul 30, 2021
(cherry picked from commit b290b02)
@SaurabhTotey
Copy link
Member Author

Hey @amanda-phet, an RC was recently created with an attempt at filling out credits. Do these credits look good to you?

@jbphet
Copy link
Contributor

jbphet commented Jul 30, 2021

When asked about credits for graphic arts, @amanda-phet said (over Slack):

Mariah Hermsmeyer, Megan Lai, Amanda McGarry

When asked about other designers, she said:

Kathy Perkins, Ian Whitacre

SaurabhTotey pushed a commit that referenced this issue Aug 2, 2021
(cherry picked from commit b50a58c)
SaurabhTotey pushed a commit that referenced this issue Aug 2, 2021
@SaurabhTotey
Copy link
Member Author

The credits should be complete, I would just like them to be verified.

@stemilymill
Copy link

stemilymill commented Aug 11, 2021

When asked about credits for graphic arts, @amanda-phet said (over Slack):

Mariah Hermsmeyer, Megan Lai, Amanda McGarry

When asked about other designers, she said:

Kathy Perkins, Ian Whitacre

Based on this comment, Amanda should be included in the graphic arts credits and she is currently not.

phetsims/qa#695

@SaurabhTotey
Copy link
Member Author

I didn't put Amanda in the graphic arts section because she is already in the lead design section. @jbphet told me not to duplicate the name in both sections, but I asked in slack to make sure, where @pixelzoom replied "The policy is indeed no duplication. There’s no need to put Amanda in graphicArts." As such, I will close this issue, but please reopen if there are any other issues with credits.

@SaurabhTotey SaurabhTotey removed their assignment Aug 12, 2021
@SaurabhTotey
Copy link
Member Author

Reopening because @pixelzoom pointed out that this issue should stay open until the sim is published as QA credits may change.

@SaurabhTotey SaurabhTotey reopened this Aug 12, 2021
@KatieWoe
Copy link
Contributor

I believe QA credits are fine for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants