-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize Credits #39
Comments
As of code review #35, the credits are completed empty. It would be good to take a stab at filling these in before the first dev test. At this point in the development, you should know everything except QA credits. |
(cherry picked from commit b290b02)
Hey @amanda-phet, an RC was recently created with an attempt at filling out credits. Do these credits look good to you? |
When asked about credits for graphic arts, @amanda-phet said (over Slack):
When asked about other designers, she said:
|
(cherry picked from commit b50a58c)
The credits should be complete, I would just like them to be verified. |
Based on this comment, Amanda should be included in the graphic arts credits and she is currently not. |
I didn't put Amanda in the graphic arts section because she is already in the lead design section. @jbphet told me not to duplicate the name in both sections, but I asked in slack to make sure, where @pixelzoom replied "The policy is indeed no duplication. There’s no need to put Amanda in graphicArts." As such, I will close this issue, but please reopen if there are any other issues with credits. |
Reopening because @pixelzoom pointed out that this issue should stay open until the sim is published as QA credits may change. |
I believe QA credits are fine for this |
Standard code review issue created for #35. Should be addressed before publication.
The text was updated successfully, but these errors were encountered: