-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI sound on pick up/ drop #33
Comments
I forgot to update the class to |
Sounds are good for all representations except the number line. For some reason, there are tick mark sounds on some but not all tick marks. Seems random to me, but maybe there's a logic to it. In the video below, I didn't let go of the handle at all, except to change the value of the addends. I think there needs to be a sound at every tick mark, regardless of whether the user has dropped the handle, in addition to grab/drop. There are currently no sounds for pickup/drop when the handle is grabbed or dropped, just some of the tick marks. Screen.Recording.2024-12-03.at.3.00.05.PM.mov |
I actually flagged that in another issue. #37 I'll go ahead and close this one as completed then. Thanks! |
Oops sorry just reread this part: Adding the pickup/drop sound to the slider would be changing it's common code implementation. That's not within scope for this particular sim unless we want to revisit the general sound design for slider. |
It appears that the UI sound for pick up and drop are active for the kittens, but I didn't hear any sounds for the other representations.
Can we turn on the UI drag/drop sounds for all other representations?
The text was updated successfully, but these errors were encountered: