-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credits for 1.1 #201
Comments
@pixelzoom and I talked about how the credits between Number Play and Number Compare will begin to diverge during dev test, as well as how they will most likely be completely different for Number Pairs. In this case factoring out credits does not seem necessary, and the amount of duplication will be minimal between the three sims. I'm going to revert the above commits. |
@KatieWoe and @amanda-phet we are unsure if the credits here are accurate. Can you double check with the understanding QA credits may change once we go through dev testing?
|
FYI... Credits typically change throughout the QA process, including after RC tests, and right up until we publish. And they need to be confirmed just before we publish. So this issue most definitely blocks publication, until @KatieWoe gives the final revisions and sign-off. |
They're ok for now, but like @pixelzoom said, they may change |
Sounds good. Sorry about removing that label @pixelzoom I was thinking about a recent meeting where we were saying block-publication will be blocking the dev test for NP, but perhaps this is safe to assume we can move forward. |
We usually alphabetize by last name, so I would update that. I'm also adding @catherinecarter since she did interviews with me. Catherine Carter, Sylvia Celedón-Pattichis, Michael Kauzmann, Chris Malley (PixelZoom, Inc.), Ariel Paul, Kathy Perkins, Marla Schulz, Ian Whitacre |
Made those changes @amanda-phet. Moving this to done in the Pistachio board as the needs for this issue prior to dev test have been met. |
@marlitas I would prefer to keep issues that may still need to be worked on for this publication out of the Done column. There are other issues that won't be worked on before starting a dev test that are staying in the Todo column, not being moved to Done. |
Although now I'm realizing that doesn't really make sense given pistachios goal for this sim for the month. I'm not sure what's going to happen to this project board after tomorrow. I removed issues that won't be addressed before starting dev testing from the project board and will likely revert to using Number Play's project board for tracking publication process. |
We are in RC, so we are ready for this. |
Please add Jaron Droder and Martin Veillette to QA credits. |
Thanks @Nancy-Salpepi, this is ready for review on phettest. I also added @zepumph. |
Looks good. |
Thanks! Patch applied above |
QA feel free to close after confirming this in the new RC. |
Looks good in rc.2 |
Complete credits for 1.0 release. QA credits will not be finalized until after final RC test.
Should credits be shared with number-compare-main.ts?
The text was updated successfully, but these errors were encountered: