Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minus sign too small/low on card #225

Closed
Tracked by #932
Nancy-Salpepi opened this issue Apr 10, 2023 · 6 comments
Closed
Tracked by #932

Minus sign too small/low on card #225

Nancy-Salpepi opened this issue Apr 10, 2023 · 6 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air m1 chip

Operating System
13.2.1

Browser
safari/chrome

Problem description
For phetsims/qa#929, on the lab screen, the minus sign isn't centered and the symbol is shorter than the others.
Screenshot 2023-04-10 at 11 58 22 AM

Looking at Equality Explorer: the minus sign is centered and its size matches the other operations.
Screenshot 2023-04-09 at 9 02 30 AM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Play‬ URL: https://phet-dev.colorado.edu/html/number-play/1.1.0-rc.1/phet/number-play_all_phet.html Version: 1.1.0-rc.1 2023-04-07 16:57:36 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.3 Safari/605.1.15 Language: en-US Window: 1258x705 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
chrisklus added a commit to phetsims/circuit-construction-kit-common that referenced this issue Apr 10, 2023
chrisklus added a commit to phetsims/projectile-motion that referenced this issue Apr 10, 2023
chrisklus added a commit to phetsims/scenery-phet that referenced this issue Apr 10, 2023
chrisklus added a commit to phetsims/number-suite-common that referenced this issue Apr 10, 2023
chrisklus added a commit that referenced this issue Apr 10, 2023
chrisklus added a commit to phetsims/number-compare that referenced this issue Apr 10, 2023
@chrisklus
Copy link
Contributor

Thanks @Nancy-Salpepi! @zepumph and I fixed this in the above commits. Can you please confirm on master for Number Play and Number Compare? Please pass to us for cherry picking if all looks good.

@chrisklus chrisklus assigned Nancy-Salpepi and unassigned chrisklus Apr 10, 2023
@Nancy-Salpepi
Copy link
Author

That is one gorgeous minus sign 🙂. Looks good in both sims. Back to you.

@amanda-phet
Copy link
Contributor

Thank you Nancy!! I have been meaning to make an issue for this for so long. Glad you caught it. And @chrisklus you used the right one :)

chrisklus added a commit that referenced this issue Apr 12, 2023
@chrisklus
Copy link
Contributor

Patches applied in the above commits

@zepumph
Copy link
Member

zepumph commented Apr 13, 2023

For QA: This is just a symbol change, ensure there is no layout weirdness or bugginess and feel free to close.

@Nancy-Salpepi
Copy link
Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants