Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick new preferences icon #233

Closed
Tracked by #932
zepumph opened this issue Apr 12, 2023 · 4 comments
Closed
Tracked by #932

Cherry pick new preferences icon #233

zepumph opened this issue Apr 12, 2023 · 4 comments
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Apr 12, 2023

Commits are complete over in phetsims/joist#919. We just need to cherry pick:

phetsims/joist@2eda3a4

The other one (phetsims/joist@5fdf39b) is just updating how we scale things, and could come along if desired to keep things in sync.
@zepumph zepumph self-assigned this Apr 12, 2023
@zepumph zepumph mentioned this issue Apr 12, 2023
Closed
chrisklus added a commit that referenced this issue Apr 12, 2023
@chrisklus
updated dependencies.json for #233
854755e
@chrisklus
Copy link
Contributor

Patches applied

@chrisklus chrisklus mentioned this issue Apr 13, 2023
Closed
17 tasks
@zepumph
Copy link
Member Author

zepumph commented Apr 13, 2023

QA Please ensure that the new preferences icon is a gear (instead of the gear/person combo), and that it looks appropriate on all devices. Feel free to close if all is good.

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Apr 13, 2023 •
edited
Loading

For rc.2: Looks good on mac + safari/chrome and iPad. Will leave open until other platforms are looked at.

@veillette
Copy link

veillette commented Apr 13, 2023 •
edited
Loading

For rc.2: it looks good on Windows 10 with Chrome and Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chrisklus @zepumph @veillette @Nancy-Salpepi