Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointer areas also when adding touch areas (object creator nodes) #70

Closed
Tracked by #932
zepumph opened this issue Apr 11, 2023 · 4 comments
Closed
Tracked by #932

Add pointer areas also when adding touch areas (object creator nodes) #70

zepumph opened this issue Apr 11, 2023 · 4 comments
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Apr 11, 2023

Here we see that touch areas are looking really nice, but there aren't expanded pointer areas. Can we add that for a bit of a usability boost?
For both of these:

image

image
zepumph added a commit that referenced this issue Apr 11, 2023
@zepumph
apply touchArea dilation to mouseArea too, #70
a5f5ba8
zepumph added a commit to phetsims/counting-common that referenced this issue Apr 11, 2023
@zepumph
apply touchArea dilation to mouseArea too, phetsims/number-suite-comm…
c0eba9e 
…on#70
@zepumph
Copy link
Member Author

zepumph commented Apr 11, 2023

And now:

image

@chrisklus chrisklus self-assigned this Apr 12, 2023
chrisklus pushed a commit that referenced this issue Apr 12, 2023
@zepumph @chrisklus
apply touchArea dilation to mouseArea too, #70
42c820c
chrisklus added a commit to phetsims/number-play that referenced this issue Apr 12, 2023
@chrisklus
updated dependencies.json for phetsims/number-suite-common#70
61cac92
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Apr 12, 2023
@zepumph @chrisklus
apply touchArea dilation to mouseArea too, phetsims/number-suite-comm…
698e169 
…on#70
chrisklus added a commit to phetsims/number-play that referenced this issue Apr 12, 2023
@chrisklus
updated dependencies.json for phetsims/number-suite-common#70
759fc07
@chrisklus
Copy link
Contributor

Patches applied above

@chrisklus chrisklus removed their assignment Apr 12, 2023
@chrisklus chrisklus mentioned this issue Apr 13, 2023
Closed
17 tasks
@zepumph
Copy link
Member Author

zepumph commented Apr 13, 2023

For QA: Mouse areas were dilated to match the touch areas, please make sure this doesn't cause any undo problems, and also enjoy the better user experience when pulling out non-card counting objects! Feel free to close if all is good.

@Nancy-Salpepi
Copy link

Looks good in rc.2. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisklus @zepumph @Nancy-Salpepi