Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Oct 22, 2024
1 parent 5a091c3 commit a5c2aaa
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion js/grunt/check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const check = async ( providedOptions?: Partial<CheckOptions> ): Promise<boolean

const startTime = Date.now();
if ( options.clean ) {
// TODO: Keep these as 'node'? https://github.com/phetsims/chipper/issues/1481
// Don't use tsx here, just node since it is for a third-part runnable.
const cleanResults = await runCommand( 'node', [ tscRunnable, '-b', '--clean' ], cwd, false );
if ( !cleanResults.success ) {
throw new Error( 'Checking failed to clean' );
Expand Down
3 changes: 2 additions & 1 deletion tsconfig-chipper.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
"js/common/**/*",
"js/npm-dependencies/**/*",
"js/grunt/tasks/util/**/*",
"js/grunt/lint.ts",
"js/grunt/check.ts",
"js/grunt/lint.ts",
"js/grunt/tasks/lint.ts",
// TODO: should we split buildjson into a subsection that can be used by this one too (just phet-core?) // TODO: split buildjson into a subsection that can be used by this one too (just phet-core?)
"../phet-core/js/types/**/*"
]
Expand Down
2 changes: 0 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
// TODO: Remove devDependencies from chipper and use many of them from perennial-alias, https://github.com/phetsims/perennial/issues/364
// TODO: If you want to use optionize() in perennial, we need to move it from phet-core to perennial-alias. Or JO HELP, https://github.com/phetsims/perennial/issues/371
// TODO: Doesn't shared/tsconfig-node and core need to be in perennial-alias? https://github.com/phetsims/perennial/issues/364
"extends": "./tsconfig/shared/tsconfig-node.json",
"include": [
"js/**/*",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig/buildtools/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
// TODO: move this file back to chipper, since perennial shouldn't know about it. https://github.com/phetsims/perennial/issues/364
// Chipper and its node dependencies is what we call "buildtools"
"compilerOptions": {
"composite": true
},
"references": [
{
// TODO:fix this so it doesn't hard code importing from chipper, https://github.com/phetsims/perennial/issues/364
"path": "../../../chipper/tsconfig-chipper-node.json"
}
]
Expand Down

0 comments on commit a5c2aaa

Please sign in to comment.