Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording of yotta query parameters for future taggability #66

Open
jonathanolson opened this issue Mar 15, 2024 · 4 comments
Open

Comments

@jonathanolson
Copy link
Contributor

Proposal is to send back query parameters (and if available, their values) that starts with yotta.

@jonathanolson jonathanolson self-assigned this Mar 15, 2024
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/area-model-decimals that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/area-model-decimals that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/area-model-introduction that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/area-model-introduction that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/atomic-interactions that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/balancing-chemical-equations that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/balloons-and-static-electricity that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/balloons-and-static-electricity that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/beers-law-lab that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/blackbody-spectrum that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/build-a-molecule that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/build-a-nucleus that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/build-an-atom that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/build-an-atom that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/calculus-grapher that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/capacitor-lab-basics that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/center-and-variability that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/charges-and-fields that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/circuit-construction-kit-ac-virtual-lab that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/collision-lab that referenced this issue Mar 18, 2024
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/quadrilateral that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/ratio-and-proportion that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/sound-waves that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/states-of-matter-basics that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/vector-addition-equations that referenced this issue Apr 3, 2024
jonathanolson added a commit to phetsims/waves-intro that referenced this issue Apr 3, 2024
@jonathanolson
Copy link
Contributor Author

In production, closing.

@zepumph
Copy link
Member

zepumph commented Nov 22, 2024

@jonathanolson can you please describe this feature? I don't know how to use it, or where it is documented. We want to be able to provide custom tags for phet-io sim runs from phet-io clients and PhET Studio presets. Can you point me in a direction?

@kathy-phet
Copy link

@zepumph @mattpen - I believe this code:

// Forward yotta-specific query parameters, see #66
for ( const [ key, value ] of new URLSearchParams( window.location.search ) ) {
if ( key.startsWith( 'yotta' ) ) {
pingParams += &${encodeURIComponent( key )}=${encodeURIComponent( value )};
}
}

Means that adding any query parameter that has yotta in it will be forwarded to yotta:
?yotta_studio_preset="preset URL" (this would have partner name and preset value in it, and could be parsed further)

@jonathanolson - is this correct? any query parameter that starts with "yotta" are then included and passed with the yotta message

@jonathanolson
Copy link
Contributor Author

is this correct? any query parameter that starts with "yotta" are then included and passed with the yotta message

Yes, they are passed and recorded. There isn't any code to USE those things yet, but they will be recorded and can be processed (historically AND going forward) whenever we'd add code to process it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants