Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming model properties related to target #251

Closed
2 tasks done
arouinfar opened this issue Feb 24, 2021 · 3 comments
Closed
2 tasks done

Renaming model properties related to target #251

arouinfar opened this issue Feb 24, 2021 · 3 comments
Assignees
@arouinfar
Labels
design:phet-io dev:phet-io status:ready-for-review

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Feb 24, 2021 •
edited by zepumph
Loading

For #244

The model properties related to the targetNode are housed under model.score which we don't find to be particularly intuitive.

Model View
image image

Things we'd like to rename:

  • Change model.score to model.target
  • Change model.score.targetXProperty to model.target.positionProperty
@zepumph zepumph mentioned this issue Jul 26, 2021
Closed
@zepumph
Copy link
Member

zepumph commented Jul 26, 2021

Change model.score to model.target

This was not just a tandem rename, but instead a whole class, so I did this in #268

zepumph added a commit that referenced this issue Jul 26, 2021
@zepumph
rename targetXProperty to positionProperty and add units, #251
8665118
@zepumph
Copy link
Member

zepumph commented Jul 26, 2021

All has been complete here, please review.

@zepumph zepumph assigned arouinfar and unassigned zepumph Jul 26, 2021
@arouinfar
Copy link
Contributor Author

Looks good in master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
design:phet-io dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @arouinfar