Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companionlessObjectType name is unclear #254

Closed
arouinfar opened this issue Feb 24, 2021 · 2 comments
Closed

companionlessObjectType name is unclear #254

arouinfar opened this issue Feb 24, 2021 · 2 comments

Comments

@arouinfar
Copy link
Contributor

For #244

@zepumph described the companionlessObjectType in #219 (comment):

These objectTypes work much like Solutes in ph-scale, where they are basically just constants that have data about how an instance of that type would behave. So if you know that the model's selectedProjectileObjectTypeProperty is cannonball, I know what the defaults will be by looking at the initialState of projectileMotion.global.model.projectileObjectTypes.cannonball:

{
 "name": "‪Cannonball‬",
 "mass": 17.6,
   "diameter": 0.18,
   "dragCoefficient": 0.47,
   "benchmark": "cannonball",
   "rotates": false,
   "massRange": {
     "min": 1,
     "max": 31
   },
   "massRound": 0.01,
   "diameterRange": {
     "min": 0.1,
     "max": 1
   },
   "diameterRound": 0.01,
   "dragCoefficientRange": {
     "min": 0.04,
     "max": 1
   }
 }

UPDATE: the companionless one is used in vectors/drag screens where you can't choose different types. That is the only (companionless) projectile type you can fire projectiles of.

"Companionless" isn't a particularly friendly/intuitive name. We would like to something clearer like genericObjectType or generalObjectType. (I don't have a preference between generic and general.)

@zepumph would this be relatively straightforward to change? Any objections?

@zepumph
Copy link
Member

zepumph commented Jul 26, 2021

I like that a lot! Good name

image

@arouinfar
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants