Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Testing for i18n of localization text #1114

Closed
21 tasks done
jessegreenberg opened this issue Jul 16, 2024 · 4 comments
Closed
21 tasks done

Maintenance Testing for i18n of localization text #1114

jessegreenberg opened this issue Jul 16, 2024 · 4 comments

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jul 16, 2024

Patches have been added to sims to fix phetsims/joist#976. Can you please do a sanity check on each of these to make sure they are OK to deploy?

Release Candidate links

area-model-algebra 1.3 (phetsims/joist#976)

area-model-decimals 1.3 (phetsims/joist#976)

area-model-introduction 1.3 (phetsims/joist#976)

area-model-multiplication 1.3 (phetsims/joist#976)

arithmetic 1.2 (phetsims/joist#976)

balancing-act 1.3 (phetsims/joist#976)

graphing-lines 1.4 (phetsims/joist#976)

graphing-slope-intercept 1.2 (phetsims/joist#976)

greenhouse-effect 1.3 (phetsims/joist#976)

hookes-law 1.1 (phetsims/joist#976)

keplers-laws 1.2 (phetsims/joist#976)

projectile-data-lab 1.0 (phetsims/joist#976)

projectile-sampling-distributions 1.0 (phetsims/joist#976)

@KatieWoe KatieWoe moved this to Active Tests (max 5, by priority) in QA Pipeline Jul 16, 2024
@KatieWoe KatieWoe moved this from Active Tests (max 5, by priority) to Upcoming Tests (by priority) in QA Pipeline Jul 16, 2024
@jessegreenberg
Copy link
Contributor Author

@KatieWoe pointed out that the bug is not reproducible in the published version of Arithmetic (1.2.2). I can't explain that, it would be good to understand why that is the case.

@KatieWoe KatieWoe moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Jul 16, 2024
@jessegreenberg
Copy link
Contributor Author

For the above note, we confirmed that the behavior is expected. The strings were previously hidden in the translataion utility, but were still to change with ?stringTest. So the test is no longer on hold.

I am not sure how to best verify that this is fixed, I will ask slack.

@KatieWoe
Copy link
Contributor

Basic MR looks ok. As discussed with @jessegreenberg, there isn't a great way for QA to check that the actual issue is fixed. If something is found, let us know and we can retest for it. Otherwise, QA is done.

@KatieWoe KatieWoe assigned jessegreenberg and unassigned KatieWoe Jul 17, 2024
@KatieWoe KatieWoe moved this from Active Tests (max 5, by priority) to Dev & RC: ready for next steps in QA Pipeline Jul 17, 2024
@jessegreenberg
Copy link
Contributor Author

OK, thanks @KatieWoe!! I am going to go ahead with the deploys. It sounds like there isn't a great way to verify this.

One thing I did to was verify that these strings are currently not available in the translation utility for sims that support dynamic locale. I will make sure that the strings are there after sims are deployed to production. Closing, and will continue in phetsims/joist#976

@github-project-automation github-project-automation bot moved this from Dev & RC: ready for next steps to Done in QA Pipeline Jul 17, 2024
@mattpen mattpen mentioned this issue Jul 25, 2024
7 tasks
@oliver-phet oliver-phet mentioned this issue Jul 25, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants