Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot check: iOS apps #1127

Closed
11 tasks done
oliver-phet opened this issue Jul 25, 2024 · 12 comments
Closed
11 tasks done

Spot check: iOS apps #1127

oliver-phet opened this issue Jul 25, 2024 · 12 comments
Assignees

Comments

@oliver-phet
Copy link
Contributor

oliver-phet commented Jul 25, 2024

iOS App Spot Check

What to test

  • Latest iOS "PhET Simulations" App: version 1.5.0 build (1) - deployed via testflight
  • Latest iOS "PhET4Schools Access Program" app: version 1.5.1 build (1) - deployed via testflight

Things to test

Devices to test

  • iPad
  • iPhone
  • (if possible) iPad <iOS 15.0 (this update now requires iOS 15.0+ so it would be nice to verify that requirement is now working)
@KatieWoe KatieWoe self-assigned this Jul 25, 2024
@KatieWoe KatieWoe moved this to Upcoming Tests (by priority) in QA Pipeline Jul 25, 2024
@KatieWoe KatieWoe moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Jul 30, 2024
@KatieWoe KatieWoe moved this from Active Tests (max 5, by priority) to Upcoming Tests (by priority) in QA Pipeline Jul 30, 2024
@KatieWoe KatieWoe moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Aug 5, 2024
@Nancy-Salpepi
Copy link
Contributor

Nancy-Salpepi commented Aug 7, 2024

@oliver-phet since this is the first time I have ever tested with an iPhone, I'm wondering if the sims were also so stretched when holding the phone vertically?
Screenshot 2024-08-07 at 3 01 54 PMScreenshot 2024-08-07 at 3 02 12 PM

@oliver-phet
Copy link
Contributor Author

@oliver-phet since this is the first time I have ever tested with an iPhone, I'm wondering if the sims were also so stretched when holding the phone vertically?

Yeah, that is expected behavior and is an accepted consequence of supporting portrait!

@Nancy-Salpepi
Copy link
Contributor

Second question @oliver-phet, the new Phet version appeared on my iPad today (yay). I turned off my wifi and opened it, but not all the sims were done downloading (they appeared gray) and clicking on one resulted in this message:
Screenshot 2024-08-07 at 3 11 56 PM
Is that expected?

@Nancy-Salpepi
Copy link
Contributor

Last question @oliver-phet (I hope)! Is it normal to see "missing" under Access Code Status? I'm wondering if that was when I was trying to figure out steps for the crash.
Screenshot 2024-08-07 at 3 41 04 PM

@oliver-phet
Copy link
Contributor Author

oliver-phet commented Aug 7, 2024

@Nancy-Salpepi to your second comment: missing is expected if an access code hasn't been entered yet. We shouldn't ever have any sim-run with missing (just app-run). If you were repeatedly opening the access code version without entering a code, I'd expect to see lots of missing. So, I don't think this is an issue.

First comment - I'd like a deeper dive into the exact steps here. There certainly shouldn't be any sims awaiting an update download immediately after opening the app (without internet). I just tested and I didn't see any sims awaiting an update upon first app launch. It would be possible to get a situation like your screenshot if you opened the app with internet and disabled internet mid-update. Can you clarify the steps to reproduce?

@Nancy-Salpepi
Copy link
Contributor

Sorry Oliver--I'm not sure what I did the first time! It is working fine on the iPad.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2024

I had at least one crash and forced close while opening the app. I told it to alert the developer, but if you want a full issue let me know.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 9, 2024

I didn't see https://github.com/phetsims/phet-ios-app/issues/637 on the iPad in the office, so it may be more device specific.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 9, 2024

Something else I noticed that I hadn't thought about before this. The iPad sim does not have heart outlines in the corners of the sims, only when they are favorited are they there. You need to go into the sim, or info dialog, to click the heart. I thought this was intentional, so I didn't mention it before (if I recall correctly this lack was in the last test too). The android app still has those heart outlines, so I'm no longer sure what the intended behavior is. If this needs an issue, let me know.

@Matthew-Moore240
Copy link

#636

I didn't see phetsims/phet-ios-app#637 on the iPad in the office, so it may be more device specific.

@Nancy-Salpepi and I are both on the same version of iOS 17.5.1 if that helps.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 9, 2024

I had just updated the one in the office to 17.6, but I think the one at home was 17.5.1, so if either of you see it, either before or after an update, recording that in the issue would be a great help.

@KatieWoe
Copy link
Contributor

QA is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants