-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev test: Energy Skate Park 1.0.0-dev.6 #470
Comments
Promoting to current top priority |
And back to the top priority |
|
I believe QA is done with this dev test |
Great, thank you @KatieWoe and team -
I am not sure #470 (comment) covered this, can you comment on if any slower platforms were tested? Ideally we want to catch performance issues now before we create an RC branch. |
Ah, sorry. I missed the bit about slowest performing. I'll reopen and take a look. |
Thank you! |
ChromeOS: Fair, some noticeable lag, particularly on third screen. FPS from 30-50 |
Great, thanks @KatieWoe - In phetsims/energy-skate-park#42 we decided that this release will not need to support iOS 9, we expected that platform to be problematic. @ariel-phet can you please comment on if more time is needed to optimize for ChromeOS? Third screen is most graphically intensive as it uses griddle, and optimizations would probably start there. But "fair" with 30-50 fps may also be acceptable. |
@KatieWoe for ChromeOS can you compare to the published version of ESPB for us? If things have some lag compared to published, we likely need to do some work @jessegreenberg considering the popularity of this platform. |
Quick look on published ESPB ChromeOS. It looked good: 55-60 fps. Honestly, I expected to get problems from phetsims/energy-skate-park-basics#467, but it looks pretty good. |
Interesting, that is surprising since it was reported as poor in phetsims/energy-skate-park-basics#467. Ill open an issue in energy-skate-park to investigate more. This issue can be closed. |
Could you please give this sim a dev test? There have been enough changes since the last version that this would be useful before an RC.
Changes mostly involve conservation of energy in special cases (phetsims/energy-skate-park#172, phetsims/energy-skate-park#45, others). So please pay special attention to the behavior of energy and make sure that it is conserved.
For this test can you also please test performance of the sim on our slowest platforms?
Link to Sim
Also assigning to @ariel-phet to provide priority.
The text was updated successfully, but these errors were encountered: