Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Balancing Act 1.2.0-rc.1 PhET-iO #473

Closed
3 tasks
chrisklus opened this issue Jan 29, 2020 · 15 comments
Closed
3 tasks

RC Test: Balancing Act 1.2.0-rc.1 PhET-iO #473

chrisklus opened this issue Jan 29, 2020 · 15 comments

Comments

@chrisklus
Copy link

chrisklus commented Jan 29, 2020

@KatieWoe, @ariel-phet, @kathy-phet, balancing-act/1.2.0-rc.1 is ready for RC testing.

This is a test for specific features that we're sending to a client, not an actual standard RC test. It also only includes PhET-iO, and is not a fully instrumented version of the sim. Per the query parameters included in the wrapper links, only the second screen needs to be tested, and with the query parameter stanford. For these reasons, much of the typical RC template has been omitted.

We're trying to deliver this to the client by the end of the week, so this is a high priority test.

Please document issues in https://github.com/phetsims/balancing-act/issues and link to this issue.

Assigning to @ariel-phet for prioritization.

PhET-iO RC Test

Focus and Special Instructions

  • Please do thorough testing of the standalone version with this link:
  • Please test the record and playback wrapper locally with these links:
  • Please do a Metacog cycle test with this link:

Here are the requests from the client that we implemented for this version:

  • Remove “People” from the simulated object box.
  • Limit the weight options of the bricks to 5kg, 10kg and 20kg.
  • It should say "setup" and "test"
  • When in "test" cannot move objects
  • Record log data of student actions
  • Have mystery boxes with the weights that are different from the weights of all the bricks.
  • Supply new values for the mystery weights

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.

@ariel-phet
Copy link
Contributor

@KatieWoe concurrent top priority with #471

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 31, 2020

  • macOS 10.12 Safari
    • standalone
    • record
    • playback
    • login
  • macOS 10.12 Chrome
    • standalone
    • record
    • playback
    • login
  • iPad iOS 13 Safari (No Studio)
    • standalone
    • login
  • macOS 10.15 Safari
    • standalone
    • record
    • playback
    • login
  • macOS 10.15 Firefox
    • standalone
    • record
    • playback
    • login ❌
  • macOS 10.15 Chrome
    • standalone
    • record
    • playback
    • login
  • Win 10 (laptop) Edge
    • standalone
    • record
    • playback
    • login
  • Win 10 (laptop) Chrome
    • standalone
    • record
    • playback
    • login
  • Win 10 (laptop) Firefox
    • standalone
    • record
    • playback
    • login ❌
  • Win 10 (laptop) IE (No Studio)
    • standalone
    • record ❌
    • playback ❌
    • login ❌
  • Chromebook Chrome (latest)
    • standalone
    • record
    • playback
    • login

@ghost
Copy link

ghost commented Feb 2, 2020

Linking https://github.com/phetsims/studio/issues/92 since it affects this sim.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2020

phetsims/balancing-act#43 may happen here, but it is quite hard to tell.

@samreid
Copy link
Member

samreid commented Feb 4, 2020

Where there is a ❌next to "login", which issue (or issues) does that refer to?

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 4, 2020

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 4, 2020

This known issue: https://github.com/phetsims/phet-io-wrappers/issues/278. Is present with metacog on iPads.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 4, 2020

QA is done. Issues linked or discussed above.

@samreid
Copy link
Member

samreid commented Feb 5, 2020

@zepumph and I reviewed the referenced issues and agreed this is ready to share with our client, but we will mention that it may not work on Chromebooks and there may be problems if you interact with an object while it's animating.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 5, 2020

QA is done. Some uncertainty in metacog discussed in phetsims/balancing-act#114. Not sure what causes it or the platform. Other issues linked above.

@KatieWoe KatieWoe assigned chrisklus and unassigned KatieWoe Feb 5, 2020
@chrisklus
Copy link
Author

In phetsims/balancing-act#115 the phet-io team cherry picked the fix for https://github.com/phetsims/studio/issues/92 and published 1.2.1.

Can we close @samreid @zepumph?

@samreid
Copy link
Member

samreid commented Feb 6, 2020

I'd like to leave this open until I have a chance to triage all the opened issues, if that's OK. But if that interferes with the QA issues, let me know and I'll find another way.

@zepumph
Copy link
Member

zepumph commented Feb 6, 2020

There look to be three BA specific issues from this QA:
phetsims/balancing-act#112
phetsims/balancing-act#95
phetsims/balancing-act#113

All other open issues have GFL linked to it, and will be covered by that RC process.

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 7, 2020

This issue sent me on a wild-goose chase related to phetsims/joist#624, trying to identify affected sims that were in dev/RC testing. I see 2 additional RCs (1.2.0-rc.2, 1.2.0-rc.3, with no QA issues) and 3 published version (1.2.0, 1.2.1, 1.2.2) on phet-dev. Can someone please document what happened here, and (if appropriate) close this issue?

@samreid
Copy link
Member

samreid commented Sep 10, 2020

This sim was published and shared with the client. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants