Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Gravity Force Lab 2.2.0-rc.1 #471

Closed
5 of 6 tasks
zepumph opened this issue Jan 28, 2020 · 20 comments
Closed
5 of 6 tasks

RC test: Gravity Force Lab 2.2.0-rc.1 #471

zepumph opened this issue Jan 28, 2020 · 20 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jan 28, 2020

@emily-phet @terracoda @jessegreenberg @arouinfar @kathy-phet, gravity-force-lab/2.2.0-rc.1 is ready for RC testing.
Document issues in https://github.com/phetsims/gravity-force-lab/issues and link to this issue.

This simulation is outfitted with:

  • All PhET-iO featured, including a designed api
  • Sound
  • Interactive Descriptions (alternative input and auditory descriptions)
  • Gesture Accessibility with support for mobile iOS

Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Check this LoL spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.

Link(s)


PhET-iO RC Test

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make sure the simulation loads without crashing or throwing errors.
  • Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:
    /wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER
    
    Further instructions in QA Book
  • Please at least load all wrappers except studio in the wrapper suite with internet explorer.
  • make sure to do a complete metacog recording/playback test. Ask @zepumph if you need help.

Link(s)


Accessibility (a11y) RC Test

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature doesn't negatively affect the sim in any way.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is "status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

Screen Readers

This sim supports screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to screen readers. If you simply need a refresher on screen readers, please consult the QA Book, which should have all of the information you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (Please test this! Especially with the Ruler interaction)

Critical Screen Reader Information

We are tracking known screen reader bugs in this Google Document. If you find a screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a screen reader.

Final Requests


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet
Copy link
Contributor

Concurrent top priority with #469

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 29, 2020

IE performance is rather poor when dragging the masses or the sliders around. Not really worth an issue in my opinion. @zepumph let me know if you disagree and want one made.
Edit: performance doesn't seem to be a problem with keyboard nav here.

@KatieWoe
Copy link
Contributor

With mobile VO, if enhanced sound is on, it can be hard to tell while the sliders are moving since three sounds are playing at once.

@zepumph
Copy link
Member Author

zepumph commented Jan 30, 2020

With mobile VO, if enhanced sound is on, it can be hard to tell while the sliders are moving since three sounds are playing at once.

Can you describe what the three sounds are? I only hear the mass "boomp" and the force "waaaah"

@emily-phet
Copy link

Since it's with VO on, maybe she's referring to the description as the third sound?

@KatieWoe
Copy link
Contributor

Yes. So description, boomp, and waaaah, with boomp being hard to detect in the mix.

@terracoda
Copy link
Contributor

@KatieWoe by boomp, do you mean the mass sound that is added when Enhanced Sound is checked? If so, that's interesting because, I think that sound has been more salient for blind users. It's been the force sound that is a little less obvious to detect.

I haven't looked too carefully at all the sound interview data for this sim, but if I am recalling correctly, several interviewees noticed that there was more than one sound happening when mass was being changed.

@KatieWoe
Copy link
Contributor

I was quoting @zepumph above. He was using it for the mass sound under enhanced sound.

@terracoda
Copy link
Contributor

And I haven't seen any interviews using mobile VO with this sim.

@KatieWoe
Copy link
Contributor

Memory Test results:
memresults

@KatieWoe
Copy link
Contributor

I looked at NVDA on the simulation wrapper in phet-io quickly. Didn't see any immediate problems. @zepumph let me know if you want a thorough testing screen readers and phet-io. I did wonder how they would handle changes made in studio, but I can't really check due to https://github.com/phetsims/studio/issues/92

@KatieWoe
Copy link
Contributor

Studio doesn't work with IE. I believe this is expected.

@zepumph
Copy link
Member Author

zepumph commented Jan 31, 2020

That is expected. Will you add that to the qa book.

@ghost
Copy link

ghost commented Jan 31, 2020

On macOS + Firefox, the sound is quieter for the first few seconds. Let me know if you'd like an issue made @zepumph.

@ghost
Copy link

ghost commented Feb 1, 2020

Sorry for the confusion as to who was doing macOS 10.12 + Safari. It's done now. QA is done with the testing matrices for the general RC and PhET-iO, but @KatieWoe might want further testing before we call an end.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2020

QA is done

@KatieWoe KatieWoe assigned zepumph and unassigned KatieWoe Feb 3, 2020
@zepumph
Copy link
Member Author

zepumph commented Feb 3, 2020

Awesome!!! Thank you!

@chrisklus
Copy link

phetsims/chipper@348ef4d needs to be cherry picked for the next RC. Once that's complete and studio is added to the list of dependencies for this RC, the studio sha should be changed from master to the sha of the repo at the time that the rest of the RC shas were taken.

@zepumph
Copy link
Member Author

zepumph commented Feb 13, 2020

Alright. Everything here is all set, I'm going to make rc.2 now.

@zepumph
Copy link
Member Author

zepumph commented Feb 13, 2020

Thanks QA!

@zepumph zepumph closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants