-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This sim is ready for Interactive Description Implementation #109
Comments
@mbarlow12, this is check-list alert to get us started. Please let me know if this works for you. I am excited to work on this sim with you! |
@terracoda the checklist is great! I've been noticing that QA has done a lot of work with testing/issue templates, and I think we should bring this to the rest of the a11y team to review & refine as a general checklist for implementing these features. |
…n summary node added to screenview, see #109
…string processing methods to ISLCStringManager, see phetsims/gravity-force-lab#109
…SLC repo, more work on scene summary, see #109
@terracoda @emily-phet I've completed work on the screen summary. Moving on to the other PDOM elements later this week. |
@mbarlow12, thanks for the update. I'll check it out. |
@terracoda I'm just seconding that this checklist looks helpful! |
Oops, I didn't mean to close the issue, only comment. |
…ing/disabling of appropriate elements, see #109
@mbarlow12, I've updated the checklist to be more specific. I hope this is helpful. I've checked off the items that are present in 2.2.0-dev.7 |
Oh, just going to check dev.8 now ;-) |
@mbarlow12, PDOM is sounding much more complete and the focus order is good. Any chance you can get an accessible Keyboard Shortcuts button in there, and potentially an accessible Keyboard Shortcuts dialog? |
@mbarlow12, the PDOM is sounding good.
|
… added, new keyboard navigation dialog, see #109
…proper string handling and address todos, see phetsims/gravity-force-lab#109
…value formatters, pdom updates see #109
…ue functions implemented, link distance display in screen summary to model property, see phetsims/gravity-force-lab#109
…ue, alert content getter added to string manager, see #109
…lemented, onFocus options for a11y input added, see phetsims/gravity-force-lab#109
…ng content, implement functions to return text for subtype aria-valuetext, remove force vector information from position alert, see phetsims/gravity-force-lab#109 and phetsims/gravity-force-lab#124
…r, a11y string pattern update, see phetsims/gravity-force-lab#109
…ructor, remove alertManager as ScreenView member, see phetsims/gravity-force-lab#124 phetsims/gravity-force-lab#109
…ge alerts, new string manager getter functions, variable renaming, see phetsims/gravity-force-lab#124 and phetsims/gravity-force-lab#109
Latest dev release at: I believe the The mass controls still have some issues, and focus alerts won't be handled until phetsims/scenery#920 is fixed. |
@mbarlow12, thanks for all your hard work and these new links! |
@zepumph can you reference this issue when you make commits to GFL Regular? |
@terracoda anything else for this issue? |
From my notes in the design doc which I did not add to this issues (apologies). I think everything but #233 has been verified:
|
Awesome! And #233 is now closed. Thanks @terracoda. |
I think we can close this issue. Everything in it is implemented, and all things outstanding (a11y related or not) are being tracked in other issues. |
A11y Features for this sim:
Link to GFL A11y Design Main
Implementation of State Descriptions (PDOM)
Change focus order to match the design document
Static State descriptions
Dynamic State descriptions are ready for PDOM, but only single examples (may need more examples)
Responsive Descriptions (drafted & ready for implementation):
Simple Context Responses
Complex Object and Context Responses
Checklist for making Measure Distance Ruler accessible
application
role andaria-roledescription="movable"
on button activationaria-roledescription="movable"
andaria-describedby
to deliver automatic instructions for first 2 grabsUpdate Keyboard Shortcuts Dialog (ready)
Check and Update credits before publishing see issue #180
Review notes after testing & listening (June 11th)
More on the Ruler Interaction
Edited Nov 29, 2019 - added: items to Ruler section, Keyboard dialog updates, Scientific Notation issue.
Edited Apr 10 - Added Ruler section - no items yet.
Edited Mar 6 - Added Update Credits
Edited Jan 22, 2019: After review updated how items were described, checked off implemented items, added notes where there are implementation issues.
Edited Jan 10, 2019: Added Keyboard Shortcuts Dialog to list
Edited: unchecked Mass slider alerts, and will create issues
Edited: added heading for descriptions.
Edited again: added specific items for PDOM, but not sure if we need this granularity.
Edited again Oct 30: added link to Keyboard Dialog section, adjusted details for the Play Area's interactive items.
The text was updated successfully, but these errors were encountered: