Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This sim is ready for Interactive Description Implementation #109

Closed
69 tasks done
terracoda opened this issue Oct 18, 2018 · 20 comments
Closed
69 tasks done

This sim is ready for Interactive Description Implementation #109

terracoda opened this issue Oct 18, 2018 · 20 comments
Assignees

Comments

@terracoda
Copy link
Contributor

terracoda commented Oct 18, 2018

A11y Features for this sim:

  • Keyboard Navigation (except ruler details: shortcut keys, large and small steps)
  • Simple Description - Started: July 23, 2018 ??
  • Full Description - Started: July 23, 2018??; Implementation started October 18, 2018; Description design complete with the Grab,Move, Release responses for the ruler on Nov 28, 2019.
  • Sonification - (near complete, similar to GFL Basics with some changes to mass sliders, and an enhanced sound for the moving the ruler)
  • Mobile A11y - large range for mass sliders could be a challenge
  • RC created - Jan 27, 2020 - RC test: Gravity Force Lab 2.2.0-rc.1 qa#471

Link to GFL A11y Design Main

Implementation of State Descriptions (PDOM)

  • Change focus order to match the design document

  • Static State descriptions

    • Regions, Headings (H1, H2s, H3s)
      • H1 for title
      • H2s for Play Area and Control Area
      • Sim-specific H3s in Play Area and/or Control Area
    • Labels and help text for all interactive items in Play Area
      • Sphere position sliders
      • Mass Controls sliders
      • Measure Distance Ruler (accessible name, aria-roledescription, & help text)
    • Labels and help text for interactive items in Control Area
      • Labels for checkboxes
      • Help text for checkboxes
      • Reset All button
    • Sim Resources (region & H2)
      • Keyboard Shortcuts Dialog
        • Visual Keyboard Shortcuts Dialog
        • Keyboard Shortcuts button added
        • Accessible content in Keyboard Shortcuts added
        • Related Interaction hint is in scene/screen summary
  • Dynamic State descriptions are ready for PDOM, but only single examples (may need more examples)

    • Dynamic descriptions for the state of the sim (a dynamic list in this case)
    • Dynamic descriptions for Mass Spheres (a dynamic list in this case)
    • Comparable density scale for when Constant Size is checked (implemented in Basics needs verification in Regular)

Responsive Descriptions (drafted & ready for implementation):
Simple Context Responses

  • Alerts for checking/unchecking checkboxes
  • Reset All alert, verified

Complex Object and Context Responses

  • Position slider (on focus)
    • aria-valuetext
    • brief focus alert read out on focus
    • edge cases - implemented but needs more work
  • Position sliders increase/decrease information
    • dynamic aria-valuetext (distance and progress)
    • edge cases - implemented but needs work
  • Mass sliders (on focus)
    • aria-valuetext
    • brief force alerts read out on focus
  • Mass sliders: mass increase/decrease information
    • aria-valuetext (value and comparative size)
    • mass-force increase/decrease alerts
    • edge cases where a mass increase affects position of same or other sphere - implemented and fixed (at least fixed in BASICS)

Checklist for making Measure Distance Ruler accessible

  • keyboard: native button with application role and aria-roledescription="movable" on button activation
  • gesture: custom (double tap and hold) interaction with aria-roledescription="movable" and aria-describedby to deliver automatic instructions for first 2 grabs
  • platform-specific responses containing specific instructions for first 2 grabs
  • general platform-independent responses for grab, move, and releases after initial 2 grabs
  • platform-specific responses for custom keyboard jump shortcuts

Update Keyboard Shortcuts Dialog (ready)

Check and Update credits before publishing see issue #180

  • Software Development: Michael Barlow, Michael Kauzmann
  • Team: Emily B. Moore, Taliesin Smith, Brianna Tomlinson
  • Sound design: Ashton Morris

Review notes after testing & listening (June 11th)

More on the Ruler Interaction

Edited Nov 29, 2019 - added: items to Ruler section, Keyboard dialog updates, Scientific Notation issue.
Edited Apr 10 - Added Ruler section - no items yet.
Edited Mar 6 - Added Update Credits
Edited Jan 22, 2019: After review updated how items were described, checked off implemented items, added notes where there are implementation issues.
Edited Jan 10, 2019: Added Keyboard Shortcuts Dialog to list
Edited: unchecked Mass slider alerts, and will create issues
Edited: added heading for descriptions.
Edited again: added specific items for PDOM, but not sure if we need this granularity.
Edited again Oct 30: added link to Keyboard Dialog section, adjusted details for the Play Area's interactive items.

@terracoda
Copy link
Contributor Author

@mbarlow12, this is check-list alert to get us started. Please let me know if this works for you. I am excited to work on this sim with you!

@mbarlow12
Copy link
Contributor

@terracoda the checklist is great! I've been noticing that QA has done a lot of work with testing/issue templates, and I think we should bring this to the rest of the a11y team to review & refine as a general checklist for implementing these features.

mbarlow12 added a commit that referenced this issue Oct 18, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 21, 2018
mbarlow12 added a commit that referenced this issue Oct 21, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 22, 2018
@mbarlow12
Copy link
Contributor

@terracoda
Copy link
Contributor Author

@mbarlow12, thanks for the update. I'll check it out.

@mbarlow12 mbarlow12 reopened this Oct 23, 2018
@emily-phet
Copy link

@terracoda I'm just seconding that this checklist looks helpful!

mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 24, 2018
@terracoda
Copy link
Contributor Author

Oops, I didn't mean to close the issue, only comment.

mbarlow12 added a commit that referenced this issue Oct 26, 2018
@terracoda
Copy link
Contributor Author

@mbarlow12, I've updated the checklist to be more specific. I hope this is helpful.

I've checked off the items that are present in 2.2.0-dev.7

@terracoda
Copy link
Contributor Author

Oh, just going to check dev.8 now ;-)

@terracoda
Copy link
Contributor Author

@mbarlow12, PDOM is sounding much more complete and the focus order is good.

Any chance you can get an accessible Keyboard Shortcuts button in there, and potentially an accessible Keyboard Shortcuts dialog?

@terracoda
Copy link
Contributor Author

@mbarlow12, the PDOM is sounding good.
When you next work this the PDOM still needs:

  • Label and help text for Ruler
  • Help text for Mass Control sliders (1 for both)
  • Keyboard Dialog items (Button, Visual & A11y Content for dialog)
  • Help text for the Control Area checkboxes

mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 31, 2018
mbarlow12 added a commit that referenced this issue Oct 31, 2018
mbarlow12 added a commit to phetsims/gravity-force-lab-basics that referenced this issue Oct 31, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 2, 2018
mbarlow12 added a commit that referenced this issue Nov 2, 2018
mbarlow12 added a commit to phetsims/gravity-force-lab-basics that referenced this issue Nov 2, 2018
…ue functions implemented, link distance display in screen summary to model property, see phetsims/gravity-force-lab#109
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 5, 2018
mbarlow12 added a commit that referenced this issue Nov 29, 2018
…ue, alert content getter added to string manager, see #109
mbarlow12 added a commit to phetsims/gravity-force-lab-basics that referenced this issue Nov 29, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 29, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Dec 4, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Dec 10, 2018
…ng content, implement functions to return text for subtype aria-valuetext, remove force vector information from position alert, see phetsims/gravity-force-lab#109 and phetsims/gravity-force-lab#124
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Dec 10, 2018
mbarlow12 added a commit to phetsims/gravity-force-lab-basics that referenced this issue Dec 13, 2018
mbarlow12 added a commit that referenced this issue Dec 13, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Dec 13, 2018
mbarlow12 added a commit that referenced this issue Dec 18, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Dec 18, 2018
@mbarlow12
Copy link
Contributor

Latest dev release at:
https://phet-dev.colorado.edu/html/gravity-force-lab/2.2.0-dev.11/phet/gravity-force-lab_en_phet.html
and
https://phet-dev.colorado.edu/html/gravity-force-lab/2.2.0-dev.11/phet/gravity-force-lab_a11y_view.html

I believe the aria-valuetext content is correct for the mass and position sliders for most if not all edge cases. Alerts for the position sliders also appear to be correct.

The mass controls still have some issues, and focus alerts won't be handled until phetsims/scenery#920 is fixed.

@terracoda
Copy link
Contributor Author

@mbarlow12, thanks for all your hard work and these new links!

@terracoda terracoda assigned terracoda and unassigned mbarlow12 Jan 22, 2019
@terracoda
Copy link
Contributor Author

@zepumph can you reference this issue when you make commits to GFL Regular?

@terracoda terracoda mentioned this issue Nov 29, 2019
@zepumph zepumph changed the title This sim is ready for Description Implementation This sim is ready for Interactive Description Implementation Jan 13, 2020
@zepumph
Copy link
Member

zepumph commented Jan 28, 2020

@terracoda anything else for this issue?

@terracoda
Copy link
Contributor Author

terracoda commented Jan 28, 2020

From my notes in the design doc which I did not add to this issues (apologies). I think everything but #233 has been verified:

@zepumph
Copy link
Member

zepumph commented Jan 28, 2020

Awesome! And #233 is now closed. Thanks @terracoda.

@terracoda
Copy link
Contributor Author

I think we can close this issue. Everything in it is implemented, and all things outstanding (a11y related or not) are being tracked in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants