Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "closest" region name when spheres are the closest they can be. #178

Closed
terracoda opened this issue Sep 24, 2019 · 10 comments
Closed

No "closest" region name when spheres are the closest they can be. #178

terracoda opened this issue Sep 24, 2019 · 10 comments
Assignees

Comments

@terracoda
Copy link
Contributor

As mentioned in phetsims/gravity-force-lab-basics#173 (comment), let's look at re-implementing the region names to make sure the described position ranges are correct in this sim, too. "Closest" is a single-value region like "Farthest from".

I'll check the design doc for GFL regular, too, to see what's there.

@terracoda terracoda self-assigned this Sep 24, 2019
@terracoda terracoda changed the title No "closest" region name when spheres are the clostest they can be. No "closest" region name when spheres are the closest they can be. Oct 8, 2019
@zepumph
Copy link
Member

zepumph commented Oct 8, 2019

@terracoda and I noticed this too. I think we can try to figure that out now. It may be because #173 where we increased the min mass value on the NumberControls. I'll take a look

@zepumph zepumph assigned zepumph and unassigned terracoda Oct 8, 2019
@zepumph
Copy link
Member

zepumph commented Oct 8, 2019

I'll take a look at the table regions in the design doc too to see how things have changed.

@zepumph
Copy link
Member

zepumph commented Oct 8, 2019

The current values in the design doc are what are in the sim. The issue is that when we increased the min mass to 10kg from 1, we changed the min distance, and left the position regions stale. Now the min distance for the sim is

Note that this directly relates to phetsims/a11y-research#146, since changing the range in #173 left the hard coded regions in the position describers in the dust. That said, this doesn't need to be fixed in GFLB.

For this issue, @terracoda please update the design document with a min of .6, and we will meet up over in phetsims/a11y-research#146 to decide on a general solution for this issue.

@terracoda
Copy link
Contributor Author

@zepumph, I updated the Table for the size of the force vectors and the effort of the robots

Size Force Vectors (force) New Ranges (micronewtons) Effort of Robots(counter force)
tiny 0.000 072 - 0.166851 pull very little
very small 0.166852 - 2.206306 pull a little
small 2.206307 - 4.412614 pull lightly
medium size 4.412615 - 8.687336 pull gently
large 8.687337 - 19.856767 pull moderately
very large 19.856768 - 35.300919 pull hard
huge 35.300920 - 55.157686 pull very hard

I think I may still need to look at the regions table describing the actual distances.

@terracoda
Copy link
Contributor Author

terracoda commented Oct 16, 2019

@zepumph here's the adjusted regions, but keep in mind in this sims we don't rely on the region ranges for delivery a qualitatively described experience. We only use the quantitative distance value in this sim. The region names are only needed in some context responses.

Farthest from Extremely from Very far from Far from Not so close to Close to Very close to Extremely close to Closest to
9.6 9.5 - 8.6 8.5 - 7.6 7.5 - 5.6 4.5 - 3.6 3.5 - 2.6 2.5 - 1.6 1.5 - 0.7 0.6

Please see design doc for more details on how the region names are not used as much in this sim. This is because there is no Distance checkbox. We use the quantitative values as the default object responses for this sim. In the BASICS sims there are 2 distinct experiences: one qualitative and the other quantitative.

@terracoda
Copy link
Contributor Author

@zepumph, assigning back to you. Let me know if/when you need anything else or anythign more for phetsims/a11y-research#146

@zepumph
Copy link
Member

zepumph commented Nov 5, 2019

I updated the tables. I'm going to go ahead and close this issue, and keep going in phetsims/a11y-research#146 for a general solution to hard coded tables.

@zepumph
Copy link
Member

zepumph commented Dec 10, 2019

@terracoda said over in phetsims/a11y-research#146 (comment):

@zepumph, just a note that I still don't hear "closest" when the mass spheres are closest see closed issue #178

Reopening :)

@zepumph zepumph reopened this Dec 10, 2019
@zepumph
Copy link
Member

zepumph commented Dec 10, 2019

@terracoda can you please state the platform device screen reader that you are not hearing the "closest" alert for?

@terracoda
Copy link
Contributor Author

Apoloigies @zepumph, this is indeed fixed. It's possible, I only checked with Constant Size checked and not with the m1 and m2 2 set to their smallest size and closest.

I hear "closest" when the masses are 0.6 meters apart.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants