-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No "closest" region name when spheres are the closest they can be. #178
Comments
@terracoda and I noticed this too. I think we can try to figure that out now. It may be because #173 where we increased the min mass value on the NumberControls. I'll take a look |
I'll take a look at the table regions in the design doc too to see how things have changed. |
The current values in the design doc are what are in the sim. The issue is that when we increased the min mass to 10kg from 1, we changed the min distance, and left the position regions stale. Now the min distance for the sim is Note that this directly relates to phetsims/a11y-research#146, since changing the range in #173 left the hard coded regions in the position describers in the dust. That said, this doesn't need to be fixed in GFLB. For this issue, @terracoda please update the design document with a min of .6, and we will meet up over in phetsims/a11y-research#146 to decide on a general solution for this issue. |
@zepumph, I updated the Table for the size of the force vectors and the effort of the robots
I think I may still need to look at the regions table describing the actual distances. |
@zepumph here's the adjusted regions, but keep in mind in this sims we don't rely on the region ranges for delivery a qualitatively described experience. We only use the quantitative distance value in this sim. The region names are only needed in some context responses.
Please see design doc for more details on how the region names are not used as much in this sim. This is because there is no Distance checkbox. We use the quantitative values as the default object responses for this sim. In the BASICS sims there are 2 distinct experiences: one qualitative and the other quantitative. |
@zepumph, assigning back to you. Let me know if/when you need anything else or anythign more for phetsims/a11y-research#146 |
I updated the tables. I'm going to go ahead and close this issue, and keep going in phetsims/a11y-research#146 for a general solution to hard coded tables. |
@terracoda said over in phetsims/a11y-research#146 (comment):
Reopening :) |
@terracoda can you please state the platform device screen reader that you are not hearing the "closest" alert for? |
Apoloigies @zepumph, this is indeed fixed. It's possible, I only checked with Constant Size checked and not with the m1 and m2 2 set to their smallest size and closest. I hear "closest" when the masses are 0.6 meters apart. Closing. |
As mentioned in phetsims/gravity-force-lab-basics#173 (comment), let's look at re-implementing the region names to make sure the described position ranges are correct in this sim, too. "Closest" is a single-value region like "Farthest from".
I'll check the design doc for GFL regular, too, to see what's there.
The text was updated successfully, but these errors were encountered: