Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SliderKeyboardHelpSection with more options #635

Closed
1 task
zepumph opened this issue Oct 17, 2020 · 4 comments
Closed
1 task

Update SliderKeyboardHelpSection with more options #635

zepumph opened this issue Oct 17, 2020 · 4 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Oct 17, 2020

In phetsims/ratio-and-proportion#82, a slider variation was desired for the ratio hands. Instead of duplicating this all over the place, I think making the slider keyboard section more powerful is the way to go. Basically the customization needed is to:

  • Change the title (already supported)
  • Change the verb (from "adjust" to something else, like "move")
  • Maximum word (bottom sometimes)
  • Minimum word (top sometimes)
  • Provide a noun to overwrite "slider" (like " left or right hand")
  • Note that GFL implements a custom section very similar to this, and we likely should change that once this is implemented.
@zepumph zepumph self-assigned this Oct 17, 2020
@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2020

We have to be careful here, as published sims have been sent out with string keys used in this dialog, so we may need to add new ones without removing the current, hard-coded ones.

@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2020

@jessegreenberg could you give this a spot check before I take over the conversion of GFL. Note that I kept old keys for published versions.

@jessegreenberg
Copy link
Contributor

Looks good to me. I checked that the keys in d476145 were not in any translations, so it seems safe. Thanks!

@zepumph
Copy link
Member Author

zepumph commented Jan 28, 2021

Thanks.

@zepumph zepumph closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants