Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt-input support for time-based FireListeners #1117

Open
jessegreenberg opened this issue Nov 17, 2020 · 2 comments
Open

Add alt-input support for time-based FireListeners #1117

jessegreenberg opened this issue Nov 17, 2020 · 2 comments

Comments

@jessegreenberg
Copy link
Contributor

We will need support for buttons that have fireOnHold and related time-based intervals like fireOnHoldDelay and fireOnHoldInterval. Currently these are supported by the PDOM implementation in PressListener because the firing happens in response to single click events. This was discussed in detail in #939 and #931. The result of those issues is that we would like to do the following:

  • Add a way to opt-out of the click listener in PressListener.
  • Create a listener that fires in response to keydown/keyup events instead.
  • Time-based buttons throughout PhET should use this new listener and change their PDOM representation from button to role=application so that they receive the keydown and keyup events.

We will work on this the next time we encounter a sim with a time-based button.

@zepumph
Copy link
Member

zepumph commented Mar 20, 2023

Probably good to mention #1298 to track alt input generally.

@zepumph zepumph changed the title Add support for time-based buttons Add alt-input support for time-based FireListeners Feb 23, 2024
@zepumph
Copy link
Member

zepumph commented Feb 23, 2024

Very related to the sun button support needed in phetsims/sun#857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants