Skip to content

Commit

Permalink
#445 TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jan 19, 2019
1 parent 536016d commit 0d84d6c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions js/ComboBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@ define( require => {
}
} );

//TODO sun#445 why is this listener on button? this entire listener appear to be related to the list.
// add the button accessibility listener
this.button.addInputListener( {

//TODO sun#445 handle this in ComboBoxListBox
a11yclick: () => {

//TODO sun#314 order dependency, requires that showList was called first by button listener
Expand All @@ -156,7 +156,6 @@ define( require => {
}
},

//TODO sun#314 why is this on the button, shouldn't it be on the list?
// listen for escape to hide the list when focused on the button
keydown: event => {
if ( this.listBox.visible ) {
Expand Down

0 comments on commit 0d84d6c

Please sign in to comment.