add checkboxOptions to VerticalCheckboxGroup, #344

Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
phetsims · Aug 15, 2018 · 3956ff7 · 3956ff7
1 parent dbf549e
commit 3956ff7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/js/VerticalAquaRadioButtonGroup.js b/js/VerticalAquaRadioButtonGroup.js
@@ -41,8 +41,8 @@ define( function( require ) {
 
     options = _.extend( {
 
-      // options passed to constructor of the AquaRadioButtons
-      radioButtonOptions: {},
+      // {Object|null} options passed to constructor of the AquaRadioButtons
+      radioButtonOptions: null,
 
       // dilation of pointer areas for each radio button, y dimension is computed
       touchAreaXDilation: 0,

diff --git a/js/VerticalCheckboxGroup.js b/js/VerticalCheckboxGroup.js
@@ -32,17 +32,16 @@ define( function( require ) {
 
     options = _.extend( {
 
+      // {Object|null} options passed to constructor of the Checkbox
+      checkboxOptions: null,
+
       // dilation of pointer areas, y dimension is computed
       touchAreaXDilation: 5,
       mouseAreaXDilation: 5,
 
       //TODO #344 this is the total of left and right margins, replace with xMargin?
       padding: 8,
 
-      //TODO #344 these are passed to Checkbox, replace with checkboxOptions: {...}
-      boxWidth: 21,
-      checkboxColor: 'black',
-
       // supertype options
       spacing: 10, // vertical spacing
       align: 'left',
@@ -72,11 +71,9 @@ define( function( require ) {
         children: [ new HStrut( maxWidth + options.padding - indent ), item.node ]
       } );
 
-      var checkbox = new Checkbox( content, item.property, {
-        checkboxColor: options.checkboxColor,
-        boxWidth: options.boxWidth,
+      var checkbox = new Checkbox( content, item.property, _.extend( {}, options.checkboxOptions, {
         tandem: item.tandem || Tandem.optional
-      } );
+      } ) );
 
       // set pointer areas, y dimensions are computed
       var yDilation = options.spacing / 2;