check isFocusable before focusing to support displayOnlyProperty, #451

phetsims · Jan 7, 2025 · 445b94c · 445b94c
1 parent b06110c
commit 445b94c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/js/ComboBox.ts b/js/ComboBox.ts
@@ -310,8 +310,12 @@ export default class ComboBox<T> extends WidthSizable( Node ) {
     this.listBox = new ComboBoxListBox( property, items, nodes,
       this.hideListBox.bind( this ), // callback to hide the list box
       () => {
-        this.button.blockNextVoicingFocusListener();
-        this.button.focus();
+
+        // Check that it is focusable, for example, displayOnlyProperty can change that state, see https://github.com/phetsims/sun/issues/451
+        if ( this.button.isFocusable() ) {
+          this.button.blockNextVoicingFocusListener();
+          this.button.focus();
+        }
       },
       this.button,
       options.tandem.createTandem( 'listBox' ), {