hideList should be a noop if the list is not visible, #445

phetsims · Jan 20, 2019 · 46078f6 · 46078f6
1 parent 4c63c3c
commit 46078f6
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/js/ComboBox.js b/js/ComboBox.js
@@ -230,7 +230,6 @@ define( require => {
      * @public
      */
     showList() {
-
       if ( !this.listBox.visible ) {
         this.phetioStartEvent( 'popupShown' );
 
@@ -251,16 +250,18 @@ define( require => {
      * @public
      */
     hideList() {
-      this.phetioStartEvent( 'popupHidden' );
+      if ( this.listBox.visible ) {
+        this.phetioStartEvent( 'popupHidden' );
 
-      if ( this.display && this.display.hasInputListener( this.clickToDismissListener ) ) {
-        this.display.removeInputListener( this.clickToDismissListener );
-        this.display = null;
-      }
+        if ( this.display && this.display.hasInputListener( this.clickToDismissListener ) ) {
+          this.display.removeInputListener( this.clickToDismissListener );
+          this.display = null;
+        }
 
-      this.listBox.visible = false;
+        this.listBox.visible = false;
 
-      this.phetioEndEvent();
+        this.phetioEndEvent();
+      }
     },
 
     /**