updates to FireListener instrumentation, phetsims/scenery#1676

phetsims · Dec 13, 2024 · f03d623 · f03d623
1 parent c43710c
commit f03d623
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/js/AquaRadioButton.ts b/js/AquaRadioButton.ts
@@ -187,7 +187,9 @@ export default class AquaRadioButton<T> extends WidthSizable( Voicing( Node ) )
     };
     const fireListener = new FireListener( {
       fire: fire,
-      tandem: options.tandem.createTandem( 'fireListener' )
+
+      // Purposefully no nesting here, because we want the firedEmitter at the top level, and we don't instrument the enabledProperty
+      tandem: options.tandem
     } );
     this.addInputListener( fireListener );
 

diff --git a/js/Checkbox.ts b/js/Checkbox.ts
@@ -203,7 +203,8 @@ export default class Checkbox extends WidthSizable( Voicing( Node ) ) {
         }
       },
 
-      tandem: options.tandem.createTandem( 'fireListener' )
+      // Purposefully no nesting here, because we want the firedEmitter at the top level, and we don't instrument the enabledProperty
+      tandem: options.tandem
     } );
     this.addInputListener( fireListener );
 

diff --git a/js/MenuItem.ts b/js/MenuItem.ts
@@ -151,7 +151,9 @@ export default class MenuItem extends WidthSizable( Voicing( Node ) ) {
     } );
 
     this.addInputListener( new FireListener( {
-      tandem: options.tandem?.createTandem( 'fireListener' ),
+
+      // Purposefully no nesting here, because we want the firedEmitter at the top level, and we don't instrument the enabledProperty
+      tandem: options.tandem,
       fire: ( event: SceneryEvent ) => {
         closeCallback( event );
         callback( event );