Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument ComboBox with a11y #333

Closed
jessegreenberg opened this issue Jan 26, 2018 · 4 comments
Closed

Instrument ComboBox with a11y #333

jessegreenberg opened this issue Jan 26, 2018 · 4 comments
Assignees
@jessegreenberg @zepumph

Comments

@jessegreenberg
Copy link
Contributor

From phetsims/a11y-research#64, we would like to add a11y to ComboBox. I am going to take a first stab adding accessibility in a one-off branch because the focus highlight look, keyboard interaction, and output from screen reader are still being discussed. It was requested to implement an initial prototype to facilitate design decisions.
@jessegreenberg jessegreenberg self-assigned this Jan 26, 2018
@jessegreenberg jessegreenberg mentioned this issue Jan 26, 2018
Closed
jessegreenberg added a commit that referenced this issue Jan 26, 2018
@jessegreenberg
rough one-off instrumentation of a11y-combobox, see #333
0a8139f
@jessegreenberg
Copy link
Contributor Author

First pass at instrumentation has been added to the branch, we will want to clean this up before it is ready for master. But this should get us through discussion for a11y meeting on 1/26/18.

@jessegreenberg jessegreenberg mentioned this issue Jan 26, 2018
Closed
@jessegreenberg
Copy link
Contributor Author

This is on hold until we hear more about how combobox should behave with keyboard nav.

jessegreenberg added a commit that referenced this issue Feb 2, 2018
@jessegreenberg
for a11y, use a listbox with options instead of a menu with menu-item…
88f27c7 
…s, see #333 and phetsims/a11y-research#64
@pixelzoom
Copy link
Contributor

Based on the title of this issue, it appears to be a duplicate of #314. If it's somehow different, please change the title to reflect that.

@zepumph zepumph self-assigned this Oct 23, 2018
@zepumph
Copy link
Member

zepumph commented Oct 23, 2018

Indeed a duplicate of #314, closing.

@zepumph zepumph closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @jessegreenberg @zepumph