-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadioButtonGroup.md General Design Considerations, etc #364
Comments
Please assign me if you have any questions for me, thanks. |
In the above commit, I updated the "General Design Considerations" and "Aesthetic Considerations" to match the Style Guide working doc. We still need to flesh out how to separate |
@terracoda did you say you were going to look into |
…. Changes Design Doc Template text to a list for formaating purposes.
Thanks @arouinfar. I updated the PhET Component section and changed the Design Document Template to a list for formatting purposes. I also have a question for the meeting, ""Where does RadioButtonGroup.js live?" I'll un-assign myself for now. |
@terracoda I noticed this has the a11y meeting label, would you like to add this to the agenda of an upcoming a11y meeting? |
@jessegreenberg, I think we decided that the two types of radio button groups can be described in the same markdown file for now. |
@jessegreenberg, I reviewed the Binder Meeting notes from Tuesday. I think I possibly need to split the document up into CommonToAllRadioButtonGroups, RadioButtonGroup, and VerticalAquaRadioButton. I'll double check with @mbarlow12 |
I have section on Customized & Grouped Interactions in this tip sheet documenting Design Patterns for Multi-State & Customized Interactions Examples for the radiogroup interactions in BASE and RaP are provided as examples. H3: {{name for radiogroup}}, radiogroup
(Optional) Help Text: The above design pattern is the general info that is needed for the Interactive Design Document as of 2022. It can be added to the binder example when there is time. |
@amanda-phet and @arouinfar, I have committed my contributions to the RadioButtonGroup.md which now lives here https://github.com/phetsims/sun/blob/master/doc/RadioButtonGroup.md
I didn't add a section for the keyboard dialog, nor did I separate out example screen reader utterances. I created a section called "PhET Components" near the bottom, but I am not sure that's the best spot yet.
Please go to town on the General design sections, and I am happy to get feedback on any aspect of the document.
The text was updated successfully, but these errors were encountered: