Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioButtonGroup.md General Design Considerations, etc #364

Open
terracoda opened this issue May 31, 2018 · 8 comments
Open

RadioButtonGroup.md General Design Considerations, etc #364

terracoda opened this issue May 31, 2018 · 8 comments
Assignees

Comments

@terracoda
Copy link
Contributor

@amanda-phet and @arouinfar, I have committed my contributions to the RadioButtonGroup.md which now lives here https://github.com/phetsims/sun/blob/master/doc/RadioButtonGroup.md

I didn't add a section for the keyboard dialog, nor did I separate out example screen reader utterances. I created a section called "PhET Components" near the bottom, but I am not sure that's the best spot yet.

Please go to town on the General design sections, and I am happy to get feedback on any aspect of the document.

@terracoda terracoda changed the title RadioButtonGroup.md General Design considerations, etc RadioButtonGroup.md General Design Considerations, etc May 31, 2018
@terracoda
Copy link
Contributor Author

Please assign me if you have any questions for me, thanks.

@arouinfar
Copy link
Contributor

In the above commit, I updated the "General Design Considerations" and "Aesthetic Considerations" to match the Style Guide working doc.

We still need to flesh out how to separate VerticalAquaRadioButtonGroup and RadioButtonGroup so I'll leave this issue open for discussion at next week's meeting.

@arouinfar
Copy link
Contributor

@terracoda did you say you were going to look into VerticalAquaRadioButtonGroup vs RadioButtonGroup? Feel free to unassign yourself if this discussion should be left to the keyboard nav meeting.

terracoda added a commit that referenced this issue Jun 13, 2018
…. Changes Design Doc Template text to a list for formaating purposes.
@terracoda
Copy link
Contributor Author

Thanks @arouinfar. I updated the PhET Component section and changed the Design Document Template to a list for formatting purposes.

I also have a question for the meeting, ""Where does RadioButtonGroup.js live?"

I'll un-assign myself for now.

@terracoda terracoda removed their assignment Jun 13, 2018
@jessegreenberg
Copy link
Contributor

@terracoda I noticed this has the a11y meeting label, would you like to add this to the agenda of an upcoming a11y meeting?

@terracoda
Copy link
Contributor Author

terracoda commented Jun 28, 2018

@jessegreenberg, I think we decided that the two types of radio button groups can be described in the same markdown file for now.

@terracoda
Copy link
Contributor Author

@jessegreenberg, I reviewed the Binder Meeting notes from Tuesday. I think I possibly need to split the document up into CommonToAllRadioButtonGroups, RadioButtonGroup, and VerticalAquaRadioButton. I'll double check with @mbarlow12

@terracoda
Copy link
Contributor Author

I have section on Customized & Grouped Interactions in this tip sheet documenting Design Patterns for Multi-State & Customized Interactions

Examples for the radiogroup interactions in BASE and RaP are provided as examples.

H3: {{name for radiogroup}}, radiogroup
Interaction Type: radiogroup, radiobutton
Accessible name for group:
Use aria-labelledby to read group name automatically: YES/NO
Accessible names, and initial states for each radio button:

  • {{name of first radio button}}; Initial state: selected
  • {{name of second radio button}}; Initial state: not selected
  • {{name of third radio button}}; Initial state: not selected

(Optional) Help Text:
(Optional) Context Responses upon selection (or link to them):
(Optional) Design Note: Special things about this radiogroup, if any.

The above design pattern is the general info that is needed for the Interactive Design Document as of 2022. It can be added to the binder example when there is time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants