-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox cleanup #488
Comments
Transferring this issue from scenery-phet to sun, since Checkbox lives in sun. |
pixelzoom
added a commit
that referenced
this issue
Mar 28, 2019
pixelzoom
added a commit
that referenced
this issue
Mar 28, 2019
pixelzoom
added a commit
that referenced
this issue
Mar 28, 2019
pixelzoom
added a commit
that referenced
this issue
Mar 28, 2019
…disabledOpacity, fix enabledPropertyListener, #488
Work completed in the above commits. @chrisklus randomly selected to review. |
It's been a long time since this was assigned for review. @ariel-phet please prioritize. |
Dang, sorry @pixelzoom. Review complete, changes look straightforward and good to go. Back to @pixelzoom to close. |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Noticed while working on enabledProperty in another UI component.
this.content
andthis.ownsEnabledProperty
do not need to be instance fields. They are used only in the constructor. Convert them to local variables.this.enabledProperty
has no visibility annotation. Typically@public
in other UI components.Multiple lines are longer than 120 chars.
Checkbox doesn't have a demo/test in the sun demo app.
options
checkboxAppearanceStrategy
andcontentAppearanceStrategy
are unused. Other UI components have been fine with using opacity to indicate disabled, and other UI components typically havedisabledOpacity
. So switch to this in anticipation of boilerplate being replaced with a mixin or trait.Use SunConstants.DISABLE_OPACITY, rather than duplicating it.
The text was updated successfully, but these errors were encountered: