Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for IE11 #1037

Open
18 of 23 tasks
zepumph opened this issue Jun 11, 2020 · 5 comments
Open
18 of 23 tasks

Remove support for IE11 #1037

zepumph opened this issue Jun 11, 2020 · 5 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jun 11, 2020

Today we decided to remove support of IE11. Wahoo!

We will want to do the following work:

  • Make a notification Create a message that we don't support IE 11 chipper#954
  • Update QA processes to not test QA.
  • Remove workarounds already in place
    • remove polyfills like es6-promise-1e68dc.auto.min.js
    • remove polyfills like mdn-array-from-polyfill.js.
    • Remove Client.errorIfIE.
    • Client.js:156 workaround
    • I'm sure there are others
    • 14 remaining usages of platform.ie in scenery. Those are likely workarounds.
    • 35 usages of IE11 as a whole word.
    • Usage of "Internet Explorer" in WaveInterferenceControlPanel.js
    • Usage of "Internet Explorer" in initialize-globals for `?forceStubbedAudioContext"
    • Replace %1===0 with Number.isInteger, see Replace %1===0 with Number.isInteger #1039
    • Use string.includes
    • Use string.startsWith
    • replace Utils.sign with Math.sign, deprecate (or remove) Utils.sign.
  • Update CRC about IE specific workarounds
  • Remove IE11 target from transpile.js, see Remove IE 11 from transpile.js chipper#963
  • Brainstorm as a dev team if there are obvious methods/features that people will start using now but haven't been able (i.e. String.endsWith). It would be nice to be on the same page as a group.
  • Better way to run QSM: Use URLSearchParams after we drop IE support query-string-machine#36
  • MutableOptionsNode says it can use Reflect.construct when IE11 support is dropped.
  • @jonathanolson wants to be assigned to look into scenery workarounds for IE11
  • Add a checklist item to the CRC that says something like "remove any specific workaround for IE11. It is vestigial and doesn't need to be there!"

We can continue to add to this list during dev meeting discussion

@chrisklus
Copy link

from 06/18/20 dev meeting:

One part we brought up is that it would be nice for us to use built-in versions of utility functions like String.endsWith and Array.includes instead of the lodash versions going forward.

For now, we're not going to replace existing lodash usages that have built-in counterparts, but will keep that big shift as an option for the future if we find it annoying that there's occurrences of both.

As a general rule for IE workarounds, @ariel-phet says feel free to remove anything that's in the way or annoying, but no need to carefully go through and remove stuff that's not intrusive.

brandonLi8 added a commit to phetsims/chipper that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/phetcommon that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/pendulum-lab that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/number-line-operations that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/masses-and-springs that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/kite that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/griddle that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/graphing-quadratics that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/gas-properties that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/equality-explorer that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/collision-lab that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/calculus-grapher that referenced this issue Jul 10, 2020
brandonLi8 added a commit to phetsims/dot that referenced this issue Jul 10, 2020
jbphet added a commit to phetsims/number-line-operations that referenced this issue Jul 10, 2020
jbphet added a commit to phetsims/dot that referenced this issue Jul 10, 2020
jbphet added a commit to phetsims/chipper that referenced this issue Jul 10, 2020
zepumph added a commit to phetsims/qa that referenced this issue Jul 27, 2020
samreid added a commit to phetsims/graphing-lines that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/graphing-quadratics that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/graphing-slope-intercept that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/hookes-law that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/gravity-force-lab that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/griddle that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/greenhouse-effect that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/gravity-force-lab-basics that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/build-a-molecule that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/joist that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/molecule-shapes that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/wave-interference that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/wave-interference that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/phet-info that referenced this issue Nov 23, 2020
@samreid
Copy link
Member

samreid commented Nov 23, 2020

I addressed several parts in the commits above. I did not want to take the time to convert all string.indexOf to string.includes or string.startsWith, so I added that to the CRC. The remaining work for this issue is:

  • 14 remaining usages of platform.ie in scenery. Those are likely workarounds.
  • 35 usages of IE11 as a whole word, many for a Stencil support
  • @jonathanolson wants to be assigned to look into scenery workarounds for IE11

Leaving assigned to @jonathanolson for these final steps.

@samreid samreid removed their assignment Nov 23, 2020
samreid added a commit to erikjreid/save-the-town that referenced this issue Nov 23, 2020
samreid added a commit to erikjreid/save-the-town that referenced this issue Nov 23, 2020
samreid added a commit to phetsims/gravity-and-orbits that referenced this issue Nov 23, 2020
jonathanolson added a commit to phetsims/aqua that referenced this issue Jan 5, 2021
zepumph pushed a commit to phetsims/scenery that referenced this issue Dec 15, 2021
samreid pushed a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
samreid pushed a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
samreid added a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants