Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored deprecations of latest symfony and twig releases #1115

Closed
wants to merge 2 commits into from

Conversation

peterrehm
Copy link
Contributor

I did some small refactorings to update to comply with Symfony 2.7 and the upcoming Twig 2.0 release and to avoid the deprecation warnings.

It would be great if this could be merged and a new release could be created.

@peterrehm
Copy link
Contributor Author

Any oppinion on that?

@isometriks
Copy link
Collaborator

I think we'd like to keep support for 2.3 right now so you would need to keep setDefaultOptions and call configureOptions from it as 2.3 is still supported for a while as was done in some of the form types

@peterrehm
Copy link
Contributor Author

That is still the case on previous releases... I am just considering if I will continue to work on this on this repo or just on my fork.

@phiamo
Copy link
Owner

phiamo commented Nov 19, 2015

i would be pleased if we could merge this once ! thanks a lot!

@peterrehm
Copy link
Contributor Author

Closing this PR as there has not been activity. If anyone needs functionality for 2.7 / 2.8 I did some additional work here: https://github.com/peterrehm/MopaBootstrapBundle/tree/pr2.3.x

@peterrehm peterrehm closed this Dec 17, 2015
@isometriks
Copy link
Collaborator

I would merge it of you didn't remove support for 2.3, it needs the BC layer of setDefaultOptions to call configureOptions. We can think about targeting 2.7 or 2.8+ for 4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants