update target json spec to match the one in-repo #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
commented
Mar 6, 2018
| @@ -174,19 +174,18 @@ Our target specification file now looks like this: | |||
|
|
|||
| ```json | |||
| { | |||
| "llvm-target": "x86_64-unknown-none", | |||
| "llvm-target": "x86_64-unknown-linux-gnu", | |||
There was a problem hiding this comment.
i'm not sure if this is correct or not; maybe the one in-repo needs to be updated to none?
There was a problem hiding this comment.
Yeah, the in-repo version should be none, seems like I missed this.
| "disable-redzone": true, | ||
| "features": "-mmx,-sse,+soft-float" | ||
| "panic-strategy": "abort" |
There was a problem hiding this comment.
this diff is a little annoying, the only real change is the changes to linker/linker-flavor
There was a problem hiding this comment.
Could you keep the field order from the post and adjust the in-repo json file instead? (So that it is in the same order as it's introduced in the post)
There was a problem hiding this comment.
i can do this, will adjust it soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in #360 (comment)