No more RUST_TARGET_PATH #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
added
the
relnotes
phil-opp
force-pushed
the
no-more-rust-target-path
branch
from
b3652e5
to
0dd3728
Compare
phil-opp
force-pushed
the
no-more-rust-target-path
branch
from
0dd3728
to
65211f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust#49019 Rust supports passing paths as
--target(with.jsonextension). With rust-lang/cargo#5228, Cargo automatically converts these paths to absolute paths, so that theRUST_TARGET_PATHenvironment variable is no longer neccessary.The only missing piece was xargo, but unfortunatly the PR at japaric/xargo#205 got no attention. Since there are other unaddressed issues (e.g. japaric/xargo#214) and xargo is in maintainance mode, we decided to create cargo-xbuild as a simplified fork of xargo to fix these issues.
This PR updates the second edition to use
cargo xbuildinstead ofxargoand removesRUST_TARGET_PATHby passing paths as--target.