Simplify executor by merging task_queue and wake_queue #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
force-pushed
the
post-12-merge-queues
branch
from
9387b61 to
66f9972
Compare
Also: Use entry API on waker_cache map.
phil-opp
force-pushed
the
post-12-merge-queues
branch
from
66f9972 to
9887c12
Compare
phil-opp
added a commit
that referenced
this pull request
May 19, 2020
See #804 for more information.
phil-opp
added
the
relnotes
|
Post update in #805. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in #768 (comment)
This pull request also renames the
waiting_tasksmap totasksand makesrun_ready_tasksoperate on&mut Taskreferences instead of removing and re-inserting tasks from the map.As another simplification, we now use the entry API on the
waker_cachemap instead of manual if conditions. Unfortunately this requires to destructureselfinto its fields because RFC 2229 is not yet implemented (see the tracking issue), but I still think that the new approach is simpler.