Skip to content

Commit

Permalink
Fix search filter/jump radio buttons
Browse files Browse the repository at this point in the history
They do not work at all and even if they are made working, they require the present container vscode-radio-group which does not seem to expose a way to enforce the layout to be horizontal even when the space is sparse, they always wrap below one another which must not happen. Also the padding between them is too big and this cannot be modified either. Omitting the group wrapper fails because you cannot set the name attribute on those vscode radio elements individually. So all in all these elements are not fit for use here.

Fixes #114
  • Loading branch information
phil294 committed Nov 29, 2024
1 parent d8d016a commit 6756115
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions web/src/views/MainView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,14 @@
<button v-if="txt_filter" id="clear-filter" class="center" title="Clear" @click="txt_filter=''">
<i class="codicon codicon-close" />
</button>
<vscode-radio :checked="txt_filter_type == 'filter'" label="Filter" value="filter" />
<vscode-radio :checked="txt_filter_type == 'jump'" label="Jump" value="jump" title="Jump between matches with ENTER / SHIFT+ENTER or with F3 / SHIFT+F3" />
<label id="filter-type-filter" class="row align-center">
<input v-model="txt_filter_type" type="radio" value="filter">
Filter
</label>
<label id="filter-type-jump" class="row align-center" title="Jump between matches with ENTER / SHIFT+ENTER or with F3 / SHIFT+F3">
<input v-model="txt_filter_type" type="radio" value="jump">
Jump
</label>
</section>
<section id="actions" aria-roledescription="Global actions" class="center gap-5">
<git-action-button v-for="action, i of global_actions" :key="i" :git_action="action" class="global-action" />
Expand Down

0 comments on commit 6756115

Please sign in to comment.